docs: fix wording in dswap notes for blas/base/ndarray#11797
Merged
Conversation
develop commits merged 2026-04-25..2026-04-26blas/base/ndarray and ndarray/ndarraylike2scalar
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Apr 26, 2026
Other entries added in the same TS-declarations sweep use "a first one-dimensional input ndarray." / "a second one-dimensional input ndarray."; bring the dswap entry in line.
dd27b28 to
d5fdcc9
Compare
blas/base/ndarray and ndarray/ndarraylike2scalarblas/base/ndarray
kgryte
approved these changes
Apr 26, 2026
kgryte
approved these changes
Apr 26, 2026
kgryte
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fix for commits merged to
developbetween 2026-04-25T16:41:07-07:00 and 2026-04-26T05:11:55-07:00 (SHA range9135c0356..2e347f39e, 31 first-parent commits).This pull request:
blas/base/ndarray— Fix missing "a" articles indswapNotes block bullets introduced in be8badf (lib/node_modules/@stdlib/blas/base/ndarray/docs/types/index.d.ts, lines 219–220); entries read "first one-dimensional input ndarray." and "second one-dimensional input ndarray." instead of "a first one-dimensional input ndarray." and "a second one-dimensional input ndarray." consistent with every other entry in the same sweep.Related Issues
No.
Questions
No.
Other
Validation performed across the 24h commit window:
docs/style-guides/) — checked all newly added packages (ndarray/{rot180,rotl90,to-rot90,to-rotr90,unflatten,ndarraylike2scalar,base/to-rot180,base/to-rotl90},blas/ext/base/ndarray/{dunitspace,sunitspace,cunitspace,zunitspace,gunitspace}) against their reference peers.Deliberately excluded:
docs/style-guides/.Originally also included a wording change to
ndarray/ndarraylike2scalar's TypeError message; reverted per @kgryte — single-argument APIs use the "Must provide an ndarray" form (cf.ndarray/data-buffer,ndarray/dtype), and the multi-argument "First argument must be..." references the audit picked were not analogous.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as a follow-up sweep over commits merged to
developin the last 24 hours; reviewer agents flagged candidate issues, each was independently re-verified against the diff and reference peers, and only validated high-signal fixes were applied. A maintainer should still audit before promoting from draft.@stdlib-js/reviewers