Skip to content

chore: minor clean-up#11814

Merged
kgryte merged 3 commits intodevelopfrom
philipp/fix-commit-review-2026-04-27
Apr 27, 2026
Merged

chore: minor clean-up#11814
kgryte merged 3 commits intodevelopfrom
philipp/fix-commit-review-2026-04-27

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented Apr 27, 2026

Description

Follow-up fixes for commits merged to develop between 28917cf0 (2026-04-26 12:48 UTC) and 19216fd1 (2026-04-27 05:56 UTC). 20 first-parent commits in the window were audited by four parallel reviewers (two style, two bug); after dedup, re-verification, and maintainer review, three high-signal issues remain.

  • Fix @example blocks in @stdlib/blas/ext/base/dcartesian-square (a023392): index.d.ts used backtick template literals in four require calls (lib/node_modules/@stdlib/blas/ext/base/dcartesian-square/docs/types/index.d.ts, lines 41, 69, 92, 101); replaced with single quotes per style guide.
  • In d4191cc, etc/eslint/plugin/index.js (line 23) disables node/no-unpublished-require, but the plugin was migrated to eslint-plugin-n in 0dc62ae3, making the directive a no-op under the n/ prefix and tripping --report-unused-disable-directives; updated to n/no-unpublished-require.
  • Also from d4191cc, the new etc/eslint/plugin/package.json was missing the canonical "directories": {} field, which update_directories adds and which Lint Changed Files enforces; inserted to clear the failing CI lint.

Related Issues

No.

Questions

No.

Other

Validation

Checked across the 20-commit window:

  • Style-guide compliance against docs/style-guides/javascript and docs/style-guides/text, using sibling reference packages (dcusum, ddiff/sdiff, gscatter) as the gold standard.
  • Static bug scan: stride/offset arithmetic, off-by-one bounds, copy-paste mistakes in JSDoc / signature pairs, and bench-refactor format(...) substitutions versus the original concatenations.
  • Logic + security: row/column-major branches, edge-case handling (N <= 0, empty inputs), TypeScript declarations versus underlying packages.
  • Reproduced the Lint Changed Files failure locally (update_directories etc/eslint/plugin) to identify the missing directories field in etc/eslint/plugin/package.json.

Deliberately excluded:

  • Anything requiring interpretation or judgment (suggestions, "nice to haves", subjective style preferences).
  • Anything requiring code outside the diff window to validate.
  • Pre-existing node/... ESLint disable directives in files not touched by 0dc62ae3 — out of scope per the migration's incremental rollout.
  • Repeated boilerplate across the new BLAS packages — intentional per stdlib's package template.

A local report (commit-review-2026-04-27.md, kept outside the working tree) records the full review, including findings dropped during filtering and on maintainer request.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated commit-review pass over the last 24 hours of develop. Four parallel reviewer agents flagged candidate issues; each surviving issue was independently re-verified against the diff before a fix was applied. Maintainer audit expected before promoting from draft.


Comment thread lib/node_modules/@stdlib/blas/ext/base/gdiff/docs/repl.txt Outdated
Comment thread lib/node_modules/@stdlib/stats/kstest/test/test.marsaglia.js
@Planeshifter Planeshifter force-pushed the philipp/fix-commit-review-2026-04-27 branch from e5a6999 to eb75a4a Compare April 27, 2026 14:39
@Planeshifter Planeshifter changed the title fix: follow-up corrections for commits merged to develop (2026-04-26 → 2026-04-27) chore: minor clean-up Apr 27, 2026
@Planeshifter Planeshifter marked this pull request as ready for review April 27, 2026 15:07
@Planeshifter Planeshifter requested review from a team and kgryte April 27, 2026 15:07
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 27, 2026
*
* @example
* var Float64Array = require( `@stdlib/array/float64` );
* var Float64Array = require( '@stdlib/array/float64' );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter We should add a lint rule for this. Basically all strings should use single quotes. We already have a lint rule enabled for single quotes:

rules[ 'quotes' ] = [ 'error', 'single', {
.

Maybe we are dependent on your recent PR adding linting for JSDoc example source code.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 27, 2026
@kgryte kgryte merged commit 54c4bf0 into develop Apr 27, 2026
45 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-04-27 branch April 27, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants