Merged
Conversation
Planeshifter
commented
Apr 27, 2026
…/dcartesian-square` TypeScript JSDoc examples
…shim from `node/` to `n/`
e5a6999 to
eb75a4a
Compare
develop (2026-04-26 → 2026-04-27)
kgryte
reviewed
Apr 27, 2026
| * | ||
| * @example | ||
| * var Float64Array = require( `@stdlib/array/float64` ); | ||
| * var Float64Array = require( '@stdlib/array/float64' ); |
Member
There was a problem hiding this comment.
@Planeshifter We should add a lint rule for this. Basically all strings should use single quotes. We already have a lint rule enabled for single quotes:
stdlib/etc/eslint/rules/style.js
Line 1844 in 8b687a9
Maybe we are dependent on your recent PR adding linting for JSDoc example source code.
kgryte
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween28917cf0(2026-04-26 12:48 UTC) and19216fd1(2026-04-27 05:56 UTC). 20 first-parent commits in the window were audited by four parallel reviewers (two style, two bug); after dedup, re-verification, and maintainer review, three high-signal issues remain.@exampleblocks in@stdlib/blas/ext/base/dcartesian-square(a023392):index.d.tsused backtick template literals in fourrequirecalls (lib/node_modules/@stdlib/blas/ext/base/dcartesian-square/docs/types/index.d.ts, lines 41, 69, 92, 101); replaced with single quotes per style guide.d4191cc,etc/eslint/plugin/index.js(line 23) disablesnode/no-unpublished-require, but the plugin was migrated toeslint-plugin-nin0dc62ae3, making the directive a no-op under then/prefix and tripping--report-unused-disable-directives; updated ton/no-unpublished-require.d4191cc, the newetc/eslint/plugin/package.jsonwas missing the canonical"directories": {}field, whichupdate_directoriesadds and whichLint Changed Filesenforces; inserted to clear the failing CI lint.Related Issues
No.
Questions
No.
Other
Validation
Checked across the 20-commit window:
docs/style-guides/javascriptanddocs/style-guides/text, using sibling reference packages (dcusum,ddiff/sdiff,gscatter) as the gold standard.format(...)substitutions versus the original concatenations.N <= 0, empty inputs), TypeScript declarations versus underlying packages.Lint Changed Filesfailure locally (update_directories etc/eslint/plugin) to identify the missingdirectoriesfield inetc/eslint/plugin/package.json.Deliberately excluded:
node/...ESLint disable directives in files not touched by0dc62ae3— out of scope per the migration's incremental rollout.A local report (
commit-review-2026-04-27.md, kept outside the working tree) records the full review, including findings dropped during filtering and on maintainer request.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated commit-review pass over the last 24 hours of
develop. Four parallel reviewer agents flagged candidate issues; each surviving issue was independently re-verified against the diff before a fix was applied. Maintainer audit expected before promoting from draft.