build: complete eslint-plugin-n rename in override configs#11822
Open
Planeshifter wants to merge 1 commit intodevelopfrom
Open
build: complete eslint-plugin-n rename in override configs#11822Planeshifter wants to merge 1 commit intodevelopfrom
eslint-plugin-n rename in override configs#11822Planeshifter wants to merge 1 commit intodevelopfrom
Conversation
Rename two stale `node/no-unpublished-require` keys to `n/no-unpublished-require` left over from the migration in 0dc62ae. The defining file (`etc/eslint/rules/nodejs.js`) already registers the rule under the new key, so the previous override entries no longer match anything and the rule fires on every README that requires a devDependency (e.g. `eslint`). --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: skipped - task: lint_editorconfig status: skipped - task: lint_markdown status: skipped - task: lint_package_json status: skipped - task: lint_repl_help status: skipped - task: lint_javascript_src status: skipped - task: lint_javascript_cli status: skipped - task: lint_javascript_examples status: skipped - task: lint_javascript_tests status: skipped - task: lint_javascript_benchmarks status: skipped - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: skipped - task: lint_typescript_tests status: skipped - task: lint_license_headers status: skipped ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
node/no-unpublished-requirekeys ton/no-unpublished-requireleft over from the migration in 0dc62ae ("build: replaceeslint-plugin-nodewitheslint-plugin-n").etc/eslint/.eslintrc.markdown.js,etc/eslint/overrides/index.js.Related Issues
No.
Questions
No.
Other
The defining file (
etc/eslint/rules/nodejs.js) already registers the rule under the new keyn/no-unpublished-require, so the previous override entries no longer match anything and the rule fires on every README that requires a devDependency such aseslint.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code following my instructions.
@stdlib-js/reviewers