feat(mdm): add support for new ide & pluggins#22
Open
shubham-stepsecurity wants to merge 2 commits intostep-security:mainfrom
Open
feat(mdm): add support for new ide & pluggins#22shubham-stepsecurity wants to merge 2 commits intostep-security:mainfrom
shubham-stepsecurity wants to merge 2 commits intostep-security:mainfrom
Conversation
shubham-stepsecurity
force-pushed
the
sm/feat/ide
branch
from
06b7c5c to
e3e022c
Compare
There was a problem hiding this comment.
Pull request overview
Adds broader IDE/plugin detection (JetBrains, Xcode, Eclipse) and enriches extension output with a source attribute so results can distinguish bundled vs user-installed items.
Changes:
- Add detection for JetBrains IDE installations plus JetBrains/Android Studio plugins, Xcode Source Editor extensions (via
pluginkit), and Eclipse features/plugins. - Add
Extension.Source(bundled/user_installed) and update pretty output to tag bundled extensions. - Expand IDE display-name mapping to include newly supported IDE types.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/telemetry/telemetry.go | Extends ideDisplayName mapping for new IDE types in telemetry logs. |
| internal/output/pretty.go | Uses centralized ideDisplayName + displays [bundled] marker for extensions. |
| internal/model/model.go | Adds Extension.Source JSON field (omitempty). |
| internal/executor/mock.go | Adds MockDirEntry helper to support os.DirEntry-based tests. |
| internal/detector/xcode_extensions.go | New detector to parse pluginkit output for Xcode Source Editor extensions. |
| internal/detector/xcode_extensions_test.go | Unit tests for parsePluginkitLine. |
| internal/detector/jetbrains_plugins.go | New detector for JetBrains/Android Studio plugins (including bundled vs user-installed tagging). |
| internal/detector/jetbrains_plugins_test.go | Tests for JetBrains/Android Studio plugin scanning and XML parsing. |
| internal/detector/eclipse_plugins.go | New detector for Eclipse feature/plugin entries and bundled-vs-user tagging. |
| internal/detector/extension.go | Adds new extension sources (Cursor/Windsurf/Antigravity) and wires in JetBrains/Xcode/Eclipse detection. |
| internal/detector/ide.go | Adds JetBrains IDE + Android Studio + Eclipse + Xcode to IDE installation detection list. |
| internal/detector/ide_test.go | Adds test coverage for JetBrains IDE installation detection. |
| examples/sample-output.json | Updates example output to include GoLand and adjusts summary count. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+41
| // DetectEclipsePlugins scans Eclipse feature directories and returns | ||
| // all features tagged as "bundled" or "user_installed". | ||
| func (d *ExtensionDetector) DetectEclipsePlugins() []model.Extension { | ||
| var results []model.Extension | ||
| for _, dir := range eclipseFeatureDirs { | ||
| if !d.exec.DirExists(dir) { | ||
| continue | ||
| } | ||
| results = append(results, d.collectEclipseFeatures(dir)...) | ||
| } | ||
| return results | ||
| } |
Comment on lines
+13
to
+23
| func (d *ExtensionDetector) DetectXcodeExtensions(ctx context.Context) []model.Extension { | ||
| stdout, _, _, err := d.exec.RunWithTimeout(ctx, 10*time.Second, | ||
| "pluginkit", "-mAD", "-p", "com.apple.dt.Xcode.extension.source-editor") | ||
| if err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| stdout = strings.TrimSpace(stdout) | ||
| if stdout == "" { | ||
| return nil | ||
| } |
Comment on lines
+44
to
+49
| // Strip leading +/- and whitespace | ||
| enabled := false | ||
| if strings.HasPrefix(line, "+") { | ||
| enabled = true | ||
| } | ||
| line = strings.TrimLeft(line, "+- \t") |
Comment on lines
+310
to
+313
| func (e *mockDirEntry) Name() string { return e.name } | ||
| func (e *mockDirEntry) IsDir() bool { return e.dir } | ||
| func (e *mockDirEntry) Type() os.FileMode { if e.dir { return os.ModeDir }; return 0 } | ||
| func (e *mockDirEntry) Info() (os.FileInfo, error) { return &mockFileInfo{name: e.name, dir: e.dir}, nil } |
Comment on lines
+35
to
38
| func (d *ExtensionDetector) Detect(ctx context.Context, searchDirs []string) []model.Extension { | ||
| homeDir := getHomeDir(d.exec) | ||
| var results []model.Extension | ||
|
|
Comment on lines
+233
to
+239
| // readFileFromZip extracts a single file from a zip/jar archive. | ||
| func readFileFromZip(zipPath, targetFile string) []byte { | ||
| r, err := zip.OpenReader(zipPath) | ||
| if err != nil { | ||
| return nil | ||
| } | ||
| defer r.Close() |
Comment on lines
137
to
141
| "ai_agents_and_tools_count": 5, | ||
| "ide_installations_count": 3, | ||
| "ide_installations_count": 4, | ||
| "ide_extensions_count": 4, | ||
| "mcp_configs_count": 2, | ||
| "node_projects_count": 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues