Skip to content

Document MIME type detection for ambiguous file types in Media Library - #3418

Open
pwizla wants to merge 1 commit into
mainfrom
cms/media-library-mime-detection
Open

Document MIME type detection for ambiguous file types in Media Library#3418
pwizla wants to merge 1 commit into
mainfrom
cms/media-library-mime-detection

Conversation

@pwizla

@pwizla pwizla commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

This PR updates documentation based on strapi/strapi#27363.

Changes:

  • Add section to Media Library documentation explaining MIME type detection when browsers report generic file types
  • Document how Strapi handles .mov files on Windows that are reported as application/octet-stream
  • Clarify media field validation and library classification behavior

Generated automatically by the docs self-healing workflow (micro-edit, Haiku).
Review before merging.

Add section explaining how Strapi's Media Library handles file-type detection
when browsers report generic MIME types (e.g., application/octet-stream for
.mov files). This addresses user experience in media field validation and
library classification, particularly on Windows systems.

Relates to PR strapi/strapi#27363
@pwizla pwizla added flag: merge pending release Waiting for the related product PR to be merged before merging this documentation PR auto-doc-healing Automatically generated documentation PR labels Aug 28, 2026
@pwizla pwizla self-assigned this Aug 28, 2026
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
documentation Ready Ready Preview Aug 28, 2026 4:18am

Request Review

@strapi-cla

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added internal PRs created by the Strapi core team pr: chore source: CMS labels Aug 28, 2026
pwizla added a commit that referenced this pull request Aug 28, 2026
…rge override (#3419)

* fix(self-healing): report doc PRs created by the Haiku Router

The Slack notification and the run summary both read `has_targets` to
decide whether the run produced anything. That output answers a narrower
question: whether Sonnet needs to be invoked. It is set from the count of
"full" complexity PRs only.

Micro-edits are handled by the Router itself, which opens the doc PR and
records the URL in router-results.json. A run whose targets are all micro
therefore ends with has_targets=false, and was reported as an empty run.

On 2026-08-28 that produced a Slack message saying "Router (Haiku) found
no documentation targets" minutes after the Router had opened #3418.

Both reporting steps now count micro PRs alongside Sonnet's, the way the
Notion logging step already did. `has_targets` keeps its current meaning
and is only consulted to explain why Sonnet did not run.

* feat(automerge): add a maintainer override label

The eligibility checks judge form: which files, how many lines, what
shape. Form is a proxy, and a change can violate a criterion and still be
right. #3418 is the first case: it adds a heading, which check-no-headings
refuses outright, and it was reviewed and found correct.

There was no way to act on that. Adding `automerge: eligible` by hand does
not survive: the `labeled` event re-runs the workflow, the checks fail
again on the same criterion, and the label is removed minutes later.

`automerge: approved by piwi` records that a human read the PR and vouched
for it. The eligibility workflow stops re-judging a PR that carries it,
and the cron merges it alongside the gate-approved ones.

It overrides form only. The 24-hour quarantine, the required checks and
the absence period still apply, and `flag: don't merge` and `flag: merge
pending release` still block through check-labels. Merges made on the
override are marked as such in the recap, so an override is never
presented as a clean pass through the gate.
@pwizla pwizla added the automerge: approved by piwi Maintainer vouched for this PR: skip the mechanical eligibility checks and merge it label Aug 28, 2026
@pwizla pwizla added this to the 7.1.1 milestone Aug 28, 2026
@pwizla
pwizla marked this pull request as ready for review August 28, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-doc-healing Automatically generated documentation PR automerge: approved by piwi Maintainer vouched for this PR: skip the mechanical eligibility checks and merge it flag: merge pending release Waiting for the related product PR to be merged before merging this documentation PR internal PRs created by the Strapi core team pr: chore source: CMS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants