Skip to content

Improved recording file name formatting handling#1675

Merged
aleksandr-voitenko merged 5 commits intostagingfrom
recording-name-format-fixes
Apr 24, 2026
Merged

Improved recording file name formatting handling#1675
aleksandr-voitenko merged 5 commits intostagingfrom
recording-name-format-fixes

Conversation

@aleksandr-voitenko
Copy link
Copy Markdown
Collaborator

@aleksandr-voitenko aleksandr-voitenko commented Apr 22, 2026

Description

This fixes the recording filename formatter so advanced filename patterns are applied correctly when starting recordings.

Overall, this change makes the current formatter more aligned with the upstream changes.

The formatter had several issues:

  • %s was not handled
  • generated recording names still appended a resolution/random suffix like 1920x1080-13
  • filename generation only received width/height, which made it harder to support canvas-based formatting tokens consistently

This change:

  • updates filename generation to take obs_video_info * instead of a raw width/height pair
  • adds support for %s
  • adds support for additional OBS-style video tokens: %FPS, %CRES, %ORES, and %VF
  • updates simple recording, advanced recording, and ffmpeg output paths to pass the active canvas into filename generation
  • removes the unwanted resolution/random suffix behavior from generated recording filenames
  • adds regression coverage for custom advanced filename formatting in test_osn_advanced_recording.ts

Motivation and Context

This was the runtime half of the “Recordings do not follow Advanced Filename Formatting” issue.

Before this change, recordings could ignore parts of the configured format and fall back to names that looked like:

2026-04-22 16-12-121920x1080-13

After this change, the configured advanced filename pattern is used as expected.

How Has This Been Tested?

  • Manually, Windows only.
  • Unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@aleksandr-voitenko aleksandr-voitenko force-pushed the recording-name-format-fixes branch from 40358fa to 363d6c7 Compare April 22, 2026 18:55
@aleksandr-voitenko aleksandr-voitenko changed the title [WIP] Improved recording file name formatting handling Improved recording file name formatting handling Apr 22, 2026
@aleksandr-voitenko aleksandr-voitenko merged commit b3175ad into staging Apr 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants