(feat): Commands to cancel a spend request#77
Merged
kreese-stripe merged 7 commits intomainfrom May 7, 2026
Merged
Conversation
kreese-stripe
changed the title
bendavis-stripe
approved these changes
May 6, 2026
Comment on lines
+426
to
+436
| if (!storage.isAuthenticated()) { | ||
| return c.error({ | ||
| code: 'NOT_AUTHENTICATED', | ||
| message: 'Not authenticated. Run "link-cli auth login" first.', | ||
| cta: { | ||
| commands: [ | ||
| { command: 'auth login', description: 'Log in to Link' }, | ||
| ], | ||
| }, | ||
| }); | ||
| } |
Comment on lines
+452
to
+454
| waitUntilExit().then(() => { | ||
| resolve(capturedResult as SpendRequest); | ||
| }); |
Contributor
There was a problem hiding this comment.
approving as this sort of Promise structure mirrors other commands. If we wanted to change it we could, but I'd rather be consistent for now
raubrey-stripe
approved these changes
May 6, 2026
Contributor
raubrey-stripe
left a comment
raubrey-stripe
left a comment
There was a problem hiding this comment.
Tested this locally on this build, and it worked! We can follow up here, we may want to consider putting something in the skill file around (we discussed in standup)
Comment on lines
+67
to
+69
| <Text> | ||
| Status: <Text bold>{request?.status}</Text> | ||
| </Text> |
Contributor
There was a problem hiding this comment.
nit: will this always be 200? If so, we can probably remove
| | 'succeeded' | ||
| | 'failed'; | ||
| | 'failed' | ||
| | 'canceled'; |
Contributor
There was a problem hiding this comment.
lets make sure we add this into the various readme, skill, helper text etc
raubrey-stripe
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the SDK and CLI changes to support cancelling a SpendRequest via the cancellation endpoint.