fix: bump incur to 0.4.5 to fix misleading validation errors#82
Merged
bensnell-stripe merged 1 commit intomainfrom May 7, 2026
Merged
fix: bump incur to 0.4.5 to fix misleading validation errors#82bensnell-stripe merged 1 commit intomainfrom
bensnell-stripe merged 1 commit intomainfrom
Conversation
When context was provided but too short (< 100 chars), the CLI incorrectly reported "Error: missing required argument <context>" instead of the actual Zod validation message. This was fixed upstream in incur PR #138 ([email protected]) which distinguishes between truly missing fields and invalid values. Fixes LINK_AI_WALLET-208 Committed-By-Agent: claude
danhill-stripe
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
incurfrom0.4.1to0.4.5to pick up upstream fix (incur PR #138)--contextthat's too short (< 100 chars) incorrectly reportedError: missing required argument <context>instead ofError: invalid value for --context: Too small: expected string to have >=100 charactersRoot cause
[email protected]'s TTY error formatter (formatHumanValidationError) unconditionally printed "missing required argument" for everyfieldError, regardless of whether the field was actually missing or just failed validation. Fixed upstream in[email protected].Test plan
pnpm run test— all 93 tests passpnpm run typecheck— cleanlink-cli spend-request create --context "too short" ...now showsError: invalid value for --context: Too small: expected string to have >=100 characters--contextentirely still showsError: missing required option --contextFixes LINK_AI_WALLET-208