Skip to content

Pass the edge length, not its square, to the coarse NEMO viscous Jacobian #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bellonarts wants to merge 3 commits into
base: develop
Choose a base branch
from
+7 −7
Open

Pass the edge length, not its square, to the coarse NEMO viscous Jacobian #2883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53375f9
Pass the edge length, not its square, to the coarse NEMO viscous Jaco…
bellonarts Sep 3, 2026
ab76f7f
Address review: use Norm and remove duplicated fixture
bellonarts Sep 5, 2026
b8504d8
Refresh native ARM64 NEMO regression vectors
bellonarts Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SU2_CFD/src/numerics/NEMO/NEMO_diffusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ CNumerics::ResidualType<> CAvgGrad_NEMO::ComputeResidual(const CConfig *config)

su2double dist_ij_2[MAXNDIM] = {0.0};
GeometryToolbox::Distance(nDim, Coord_j, Coord_i, dist_ij_2);
dist_ij = GeometryToolbox::SquaredNorm(nDim, dist_ij_2);
dist_ij = GeometryToolbox::Norm(nDim, dist_ij_2);

for (auto iVar = 0ul; iVar < nVar; iVar++) {
for (auto jVar = 0ul; jVar < nVar; jVar++) {
Expand Down
8 changes: 4 additions & 4 deletions TestCases/parallel_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ def main():
visc_cone.cfg_dir = "nonequilibrium/visc_wedge"
visc_cone.cfg_file = "axi_visccone.cfg"
visc_cone.test_iter = 10
visc_cone.test_vals = [-5.215234, -5.739371, -20.559852, -20.509281, -20.408911, 1.262701, -3.205457, -0.015696, 0.093205, 32637.000000]
visc_cone.test_vals_aarch64 = [-5.222270, -5.746525, -20.560286, -20.510152, -20.409101, 1.255758, -3.208382, -0.016014, 0.093462, 32619.000000]
visc_cone.test_vals = [-5.215238, -5.739375, -20.581529, -20.580261, -20.508727, 1.262697, -3.205457, -0.015697, 0.093206, 32637.000000]
visc_cone.test_vals_aarch64 = [-5.215222, -5.739359, -20.581535, -20.580239, -20.508657, 1.262709, -3.205449, -0.015696, 0.093205, 32637.000000]
test_list.append(visc_cone)

# Viscous single wedge with Mutation++
Expand All @@ -209,7 +209,7 @@ def main():
super_cat.cfg_dir = "nonequilibrium/visc_wedge"
super_cat.cfg_file = "super_cat.cfg"
super_cat.test_iter = 10
super_cat.test_vals = [-5.232595, -5.757889, -20.641415, -20.640623, -20.541670, 1.246866, -3.205258, -0.028372, 0.250647, 32440.000000]
super_cat.test_vals = [-5.232595, -5.757889, -20.726945, -20.749655, -20.567151, 1.246866, -3.205258, -0.028372, 0.250647, 32440.000000]
test_list.append(super_cat)

# Viscous single wedge - partially catalytic walls
Expand All @@ -225,7 +225,7 @@ def main():
ion_gy.cfg_dir = "nonequilibrium/visc_cylinder"
ion_gy.cfg_file = "cyl_ion_gy.cfg"
ion_gy.test_iter = 10
ion_gy.test_vals = [-11.629873, -4.165562, -4.702662, -4.950351, -5.146155, -4.993878, -6.893332, 5.990109, 5.990004, -0.014849, 0.000000, 90090.000000]
ion_gy.test_vals = [-11.629871, -4.156741, -4.692113, -4.949447, -5.146196, -4.991664, -6.893329, 5.990109, 5.990004, -0.014849, 0.000000, 90090.000000]
test_list.append(ion_gy)

##########################
Expand Down
4 changes: 2 additions & 2 deletions TestCases/serial_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ def main():
visc_cone.cfg_dir = "nonequilibrium/visc_wedge"
visc_cone.cfg_file = "axi_visccone.cfg"
visc_cone.test_iter = 10
visc_cone.test_vals = [-5.215230, -5.739367, -20.560781, -20.516922, -20.406516, 1.262782, -3.205476, -0.015696, 0.093206, 32641]
visc_cone.test_vals_aarch64 = [-5.215250, -5.739384, -20.560917, -20.517096, -20.406630, 1.262772, -3.205492, -0.015695, 0.093205, 32641.000000]
visc_cone.test_vals = [-5.215233, -5.739371, -20.551239, -20.590906, -20.437427, 1.262779, -3.205476, -0.015697, 0.093207, 32641]
visc_cone.test_vals_aarch64 = [-5.215220, -5.739356, -20.551244, -20.590883, -20.437378, 1.262790, -3.205470, -0.015696, 0.093206, 32641.000000]
test_list.append(visc_cone)

#########################
Expand Down