Skip to content

ci: Fix nix-build PUSH_TO_CACHE - #2345

Merged
mmlb merged 2 commits into
developfrom
push-tsnkmlyvuyly
Aug 7, 2026
Merged

ci: Fix nix-build PUSH_TO_CACHE#2345
mmlb merged 2 commits into
developfrom
push-tsnkmlyvuyly

Conversation

@mmlb

@mmlb mmlb commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Looks like builds aren't being pushed to remote binary cache

What is the new behavior?

Builds get pushed to remote binary cache when push-to-cache is true

Additional context

Likely broken from #2319

@mmlb
mmlb force-pushed the push-tsnkmlyvuyly branch 10 times, most recently from 8145ec3 to c0ac0e8 Compare August 6, 2026 14:38
@mmlb
mmlb marked this pull request as ready for review August 6, 2026 18:28
@mmlb
mmlb requested review from a team as code owners August 6, 2026 18:28
@mmlb
mmlb force-pushed the push-tsnkmlyvuyly branch from c0ac0e8 to be1735d Compare August 6, 2026 18:29
@mmlb mmlb changed the title Fix nix-build PUSH_TO_CACHE ci: Fix nix-build PUSH_TO_CACHE Aug 6, 2026
@mmlb
mmlb force-pushed the push-tsnkmlyvuyly branch from be1735d to a73fb65 Compare August 6, 2026 21:18
@mmlb
mmlb enabled auto-merge August 6, 2026 21:19
mmlb added 2 commits August 7, 2026 07:49
Using the inputs in the run uses github workflow templating ends up
printing the secret in bash, we don't have a leak because GITHUB masks
it with `*` but thats a bug away from being a problem so lets do better.
Whoops, github is comparing the input which is a string to _true_ which
is false, need to stringify true instead.
@mmlb
mmlb force-pushed the push-tsnkmlyvuyly branch from a73fb65 to 072e349 Compare August 7, 2026 11:49
@mmlb
mmlb added this pull request to the merge queue Aug 7, 2026
Merged via the queue into develop with commit f108ef8 Aug 7, 2026
112 checks passed
@mmlb
mmlb deleted the push-tsnkmlyvuyly branch August 7, 2026 12:29
hunleyd added a commit that referenced this pull request Aug 8, 2026
…c-spool-path-defaults-onto-the-10gb-root-volume

* origin/develop: (26 commits)
  Lots of bootstrap script clean ups (#2326)
  ci: Fix nix-build PUSH_TO_CACHE (#2345)
  ci/nix-install-ephemeral: Drop sticky disk config (#2346)
  chore: bump postgres_release to cut fresh AMIs (includes #2334) (#2349)
  fix(multigres): stop base config data_directory from overriding pooler data dir (#2344)
  fix(cron): remove unnecessary TRIGGER grant on cron.job_run_details from postgres (#2334)
  chore: enable extension version restriction (warn) and cut AMIs (#2315)
  feat(nix): add site-env packages for rolling instance updates (#2283)
  ci: resolve package install sha from a flake input override (#2327)
  fix(multigres): remove dangling wal-g include from postgresql.conf (#2338)
  fix: Allow test CI pipelines to use old Int CA access. For staging only (#2330)
  chore(nix): remove maintainers field from package definitions (#2280)
  chore: bump multigres to b713432 (#2323)
  ci: Use arm-native-runner for kvm builds on aarch64-linux (#2319)
  Whole lot of ansible clean up (#2272)
  fix(ansible): drop no-op zpool loop item from zswap task (#2322)
  ci: Fix dockerhub-release-matrix matrix generation (#2320)
  chore: bump pgctld (#2318)
  fix(ansible): skip zswap params the kernel does not expose (#2321)
  feat(docker): add Dockerfile-supabase base image and rewrite Dockerfile-multigres as layered image (#2160)
  ...
hunleyd added a commit that referenced this pull request Aug 8, 2026
…nix-pkg-for-pgbackrest

* origin/develop: (36 commits)
  Lots of bootstrap script clean ups (#2326)
  ci: Fix nix-build PUSH_TO_CACHE (#2345)
  ci/nix-install-ephemeral: Drop sticky disk config (#2346)
  chore: bump postgres_release to cut fresh AMIs (includes #2334) (#2349)
  fix(multigres): stop base config data_directory from overriding pooler data dir (#2344)
  fix(cron): remove unnecessary TRIGGER grant on cron.job_run_details from postgres (#2334)
  chore: enable extension version restriction (warn) and cut AMIs (#2315)
  feat(nix): add site-env packages for rolling instance updates (#2283)
  ci: resolve package install sha from a flake input override (#2327)
  fix(multigres): remove dangling wal-g include from postgresql.conf (#2338)
  fix: Allow test CI pipelines to use old Int CA access. For staging only (#2330)
  chore(nix): remove maintainers field from package definitions (#2280)
  chore: bump multigres to b713432 (#2323)
  ci: Use arm-native-runner for kvm builds on aarch64-linux (#2319)
  Whole lot of ansible clean up (#2272)
  fix(ansible): drop no-op zpool loop item from zswap task (#2322)
  ci: Fix dockerhub-release-matrix matrix generation (#2320)
  chore: bump pgctld (#2318)
  fix(ansible): skip zswap params the kernel does not expose (#2321)
  feat(docker): add Dockerfile-supabase base image and rewrite Dockerfile-multigres as layered image (#2160)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants