Skip to content

fix: skip req metadata serialization in general case#1184

Merged
ferhatelmas merged 1 commit into
masterfrom
ferhat/req-metadata
Jun 30, 2026
Merged

fix: skip req metadata serialization in general case#1184
ferhatelmas merged 1 commit into
masterfrom
ferhat/req-metadata

Conversation

@ferhatelmas

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

reqMetadata is empty most of the time so assign string directly to skip json stringify/pino serializer overhead.

What is the new behavior?

Update type to string and initialize with empty json shape. No log changes but faster to log.

Additional context

It's serialized once when tracing is enabled, it was done twice before.

@ferhatelmas ferhatelmas requested a review from a team as a code owner June 29, 2026 09:24
Copilot AI review requested due to automatic review settings June 29, 2026 09:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coveralls

coveralls commented Jun 29, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28433157058

Coverage increased (+0.005%) to 78.811%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (4 of 5 lines covered, 80.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/http/plugins/log-request.ts 5 4 80.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12201
Covered Lines: 10057
Line Coverage: 82.43%
Relevant Branches: 7026
Covered Branches: 5096
Branch Coverage: 72.53%
Branches in Coverage %: Yes
Coverage Strength: 423.01 hits per line

💛 - Coveralls

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
@ferhatelmas ferhatelmas force-pushed the ferhat/req-metadata branch from d3a6510 to 138964d Compare June 30, 2026 09:07
@ferhatelmas ferhatelmas merged commit ac37f25 into master Jun 30, 2026
26 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/req-metadata branch June 30, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants