fix: _isSetType now detects indirect Set implementations - #5265
Open
vpelikh wants to merge 1 commit into
Open
Conversation
Replace Set.class.equals(cls) with Set.class.isAssignableFrom(cls) so that types like LinkedHashSet, HashSet, and TreeSet are correctly identified as Set types for uniqueItems schema generation. Previously only exact Set.class matches were caught, plus direct interface checks via getInterfaces() which miss inherited Set implementations. Add IsSetTypeTest with 7 test cases covering null, the Set interface, HashSet, LinkedHashSet, TreeSet, non-Set collections, and non-collection types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_isSetTypeinAbstractModelConverterfailed to recognize indirectSetimplementations such asLinkedHashSet,HashSet, andTreeSet.The old implementation only matched an exact
Set.classequality check, plus a direct interface scan viaClass.getInterfaces(). BecausegetInterfaces()only returns directly implemented interfaces, subclasses that inheritSetbehavior through a parent class (for example a custom class extendingAbstractSetor a collection extending a concrete Set) were not detected, souniqueItemswas not set on the generated schema.Change
Set.class.equals(cls)withSet.class.isAssignableFrom(cls)inprotected boolean _isSetType(Class<?> cls).false).Tests
Added
IsSetTypeTestwith 7 test cases:null-> not a SetSetinterface -> SetHashSet-> SetLinkedHashSet-> SetTreeSet-> SetList,ArrayList) -> not a SetString,Integer,Map) -> not a SetAll 7 tests pass.