Skip to content

fix: polish payment request ui - #1196

Draft
ovitrif wants to merge 5 commits into
masterfrom
ovi/polish-payment-request-ui
Draft

fix: polish payment request ui#1196
ovitrif wants to merge 5 commits into
masterfrom
ovi/polish-payment-request-ui

Conversation

@ovitrif

@ovitrif ovitrif commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

This PR polishes Payment Request screens so spacing, contact rows, amount keypad, and success layout match existing Bitkit (Contacts, Receive amount, backup success) instead of the GPT layout from #1172.

Figma is intent. Existing Bitkit components win when Figma disagrees. No flow or logic changes.

This PR was built with an orchestration UI-fix loop that compares Figma vs before vs after.

Description

  • Aligns contact rows with Contacts (Text13Up + BodyMSB, 24dp vertical).
  • Rebuilds amount edit on Receive amount (SheetTopBar 16dp, UnitButton, full NumberPad).
  • Splits the list into Incoming and Outgoing, with card glow on incoming and pending on outgoing amounts.
  • Opens Request Payment as Sheet.Receive over Home (handle, rounded sheet, host/scrim).
  • Pins sent layout to check, then PAYMENT REQUESTED, then card, then OK.
  • Shows contact name as card title and note as subtitle.

Preview

Screen Figma Before After
List
Recipient
Recipient invoice
Amount empty
Amount filled
Details
Sent

QA Notes

Manual Tests

  • 1. Figma List → Requests list: implemented matches Figma.
  • 2. Figma Recipient → Choose Recipient: implemented matches Figma.
  • 3. Figma Recipient invoice → Choose Recipient from invoice: implemented matches Figma.
  • 4. Figma Amount empty → Amount: implemented matches Figma.
  • 5. Figma Amount filled → Amount with value: implemented matches Figma.
  • 6. Figma Details → Payment Request details: implemented matches Figma.
  • 7. Figma Sent → Request sent: implemented matches Figma.

Automated Checks

  • Instrumented tests passed: CreatePaymentRequestScreenTest.kt, PaymentRequestsScreenTest.kt.
  • just compile and just lint passed locally.
  • CI: standard compile, unit test, and detekt checks run by the PR bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant