Repository navigation
ci: bump SwiftFormat to 0.64.6 - #1248
Conversation
Raise the CI version and --minversion to 0.64.6 and apply the indent and wrap changes it makes to multi-line guard conditions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The reviewed changes appear safe to merge. SummaryUpdates SwiftFormat to 0.64.6 in CI and
Reviewer model: gpt-6.1-sol Reviews (2) · Last reviewed commit: "docs: point swiftformat setup notes at 0..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Bumps the CI SwiftFormat pin and --minversion from 0.64.0 to 0.64.6 and applies the re-indentation 0.64.6 asks for on multi-line guard / if case conditions in 7 Swift files. Reviewed 8622b368, full tier (CI workflow file), static: no build, iOS does not build here.
What I checked, and 3 candidates I ruled out
Whitespace only: git diff -w master...8622b368 touches only .github/workflows/lint.yml and .swiftformat, so the 7 Swift files change indentation and nothing else. No hunk sits inside a multi-line string literal, where indentation would be content.
Pin and floor in step: SWIFTFORMAT_VERSION and --minversion both read 0.64.6, as the comment in lint.yml asks. No other workflow or script pins a SwiftFormat version (scripts/pre-commit only copies .swiftformat).
Release exists: SwiftFormat 0.64.6 is published (2026-11-06) and carries the swiftformat_linux.zip asset the install step downloads.
CI: SwiftFormat lint passed on this head with 0.64.6. Unit and integration test runs were still in progress at review time; a whitespace-only Swift change cannot move them.
Ruled out
- Local hooks on an older SwiftFormat now fail: that is what raising
--minversionis for, and it keeps local and CI formatting from disagreeing. - Unpinned download (no checksum): unchanged by this PR, same install step as before.
- README and AGENTS.md still say 0.64.0: docs, not reviewed for findings.
Merge confidence: 5/5, whitespace-only Swift changes and a config value, exercised by the green lint job.
Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the review runtime does not report an effort setting)
Pull request was converted to draft
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pwltr
left a comment
There was a problem hiding this comment.
Reviewed commit b6d1d56. SwiftFormat moves to 0.64.6 consistently in the lint workflow, .swiftformat's minimum version and both setup notes; the upstream release ships the Linux binary the workflow downloads, and the Swift changes are whitespace-only reformatting. No issues.
Review details
General review
Model: Claude Opus 5.5
Reasoning effort: high
Summary
SWIFTFORMAT_VERSIONin.github/workflows/lint.ymlfrom 0.64.0 to 0.64.6 (latest release).--minversionin.swiftformatto match.README.mdandAGENTS.md.indentandwrapchanges to multi-lineguardconditions in 7 files. Whitespace only.Test plan
swiftformat --lint .with 0.64.6 passes locally (0/850 files require formatting)8622b368)HomeHeaderUITests, 2×UsdtWalletUITests) because regtest staging Electrum was down, which is unrelated to this change. Electrum is back up.🤖 Generated with Claude Code