Skip to content

ci: bump SwiftFormat to 0.64.6 - #1248

Merged
jvsena42 merged 2 commits into
masterfrom
ci/bump-swiftformat-0.64.6
Nov 9, 2026
Merged

jvsena42 merged 2 commits into
masterfrom
ci/bump-swiftformat-0.64.6

Conversation

@jvsena42

@jvsena42 jvsena42 commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Bump SWIFTFORMAT_VERSION in .github/workflows/lint.yml from 0.64.0 to 0.64.6 (latest release).
  • Raise --minversion in .swiftformat to match.
  • Update the version in the setup notes in README.md and AGENTS.md.
  • Apply the formatting 0.64.6 requires: indent and wrap changes to multi-line guard conditions in 7 files. Whitespace only.

Test plan

  • swiftformat --lint . with 0.64.6 passes locally (0/850 files require formatting)
  • Lint workflow passes on CI (SwiftFormat check on 8622b368)
  • Unit tests pass on CI. The first run failed in 3 UI tests (HomeHeaderUITests, 2× UsdtWalletUITests) because regtest staging Electrum was down, which is unrelated to this change. Electrum is back up.

🤖 Generated with Claude Code

Raise the CI version and --minversion to 0.64.6 and apply the
indent and wrap changes it makes to multi-line guard conditions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42 jvsena42 self-assigned this Nov 9, 2026
@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The reviewed changes appear safe to merge.

Summary

Updates SwiftFormat to 0.64.6 in CI and .swiftformat, with matching whitespace changes in seven Swift files.

  • The repository now uses SwiftFormat 0.64.6 for formatting checks.

Reviewer model: gpt-6.1-sol
Reasoning effort: Not exposed
Metadata note: The host supplies the model identifier but exposes no reasoning-effort setting.

Reviews (2) · Last reviewed commit: "docs: point swiftformat setup notes at 0..." · Reviewed by Greptile

Comment thread .github/workflows/lint.yml Resolved

@talosmachina talosmachina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Bumps the CI SwiftFormat pin and --minversion from 0.64.0 to 0.64.6 and applies the re-indentation 0.64.6 asks for on multi-line guard / if case conditions in 7 Swift files. Reviewed 8622b368, full tier (CI workflow file), static: no build, iOS does not build here.

What I checked, and 3 candidates I ruled out

Whitespace only: git diff -w master...8622b368 touches only .github/workflows/lint.yml and .swiftformat, so the 7 Swift files change indentation and nothing else. No hunk sits inside a multi-line string literal, where indentation would be content.
Pin and floor in step: SWIFTFORMAT_VERSION and --minversion both read 0.64.6, as the comment in lint.yml asks. No other workflow or script pins a SwiftFormat version (scripts/pre-commit only copies .swiftformat).
Release exists: SwiftFormat 0.64.6 is published (2026-11-06) and carries the swiftformat_linux.zip asset the install step downloads.
CI: SwiftFormat lint passed on this head with 0.64.6. Unit and integration test runs were still in progress at review time; a whitespace-only Swift change cannot move them.

Ruled out

  • Local hooks on an older SwiftFormat now fail: that is what raising --minversion is for, and it keeps local and CI formatting from disagreeing.
  • Unpinned download (no checksum): unchanged by this PR, same install step as before.
  • README and AGENTS.md still say 0.64.0: docs, not reviewed for findings.

Merge confidence: 5/5, whitespace-only Swift changes and a config value, exercised by the green lint job.

Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the review runtime does not report an effort setting)

@jvsena42
jvsena42 enabled auto-merge November 9, 2026 16:44
@jvsena42
jvsena42 requested review from a team, ben-kaufman and pwltr and removed request for a team November 9, 2026 16:45
@jvsena42
jvsena42 marked this pull request as draft November 9, 2026 16:45
auto-merge was automatically disabled November 9, 2026 16:45

Pull request was converted to draft

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42
jvsena42 marked this pull request as ready for review November 9, 2026 16:46
@jvsena42
jvsena42 enabled auto-merge November 9, 2026 16:46

@pwltr pwltr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit b6d1d56. SwiftFormat moves to 0.64.6 consistently in the lint workflow, .swiftformat's minimum version and both setup notes; the upstream release ships the Linux binary the workflow downloads, and the Swift changes are whitespace-only reformatting. No issues.

Review details

General review
Model: Claude Opus 5.5
Reasoning effort: high

@jvsena42
jvsena42 requested review from a team and coreyphillips and removed request for a team November 9, 2026 17:29
@jvsena42
jvsena42 merged commit ecc41b1 into master Nov 9, 2026
40 of 41 checks passed
@jvsena42
jvsena42 deleted the ci/bump-swiftformat-0.64.6 branch November 9, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants