Skip to content

Conversation

@bluca
Copy link
Member

@bluca bluca commented Oct 5, 2025

Compiling notes.c with -O0:

Displaying notes found in: .note.dlopen
  Owner                Data size 	Description
  FDO                  0x00000088	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"fido2","description":"Support fido2 for encryption and authentication.","priority":"required","soname":["libfido2.so.1"]}]
  FDO                  0x00000084	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"pcre2","description":"Support pcre2 for regex","priority":"suggested","soname":["libpcre2-8.so.0","libpcre2-8.so.1"]}]
  FDO                  0x0000008e	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"lz4","description":"Support lz4 decompression in journal and coredump files","priority":"recommended","soname":["liblz4.so.1"]}]
  FDO                  0x00000095	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"tpm","priority":"recommended","soname":["libtss2-mu.so.0"]}, {"feature":"tpm","priority":"recommended","soname":["libtss2-esys.so.0"]}]

With -O2:

Displaying notes found in: .note.dlopen
  Owner                Data size 	Description
  FDO                  0x00000095	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"tpm","priority":"recommended","soname":["libtss2-mu.so.0"]}, {"feature":"tpm","priority":"recommended","soname":["libtss2-esys.so.0"]}]
  FDO                  0x0000008e	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"lz4","description":"Support lz4 decompression in journal and coredump files","priority":"recommended","soname":["liblz4.so.1"]}]
  FDO                  0x00000084	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"pcre2","description":"Support pcre2 for regex","priority":"suggested","soname":["libpcre2-8.so.0","libpcre2-8.so.1"]}]
  FDO                  0x00000088	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"fido2","description":"Support fido2 for encryption and authentication.","priority":"required","soname":["libfido2.so.1"]}]

So the test fails if -O2 is the default as the order is different

Follow-up for c2d3548

@bluca bluca requested a review from keszybz October 5, 2025 18:43
Compiling notes.c with -O0:

Displaying notes found in: .note.dlopen
  Owner                Data size 	Description
  FDO                  0x00000088	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"fido2","description":"Support fido2 for encryption and authentication.","priority":"required","soname":["libfido2.so.1"]}]
  FDO                  0x00000084	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"pcre2","description":"Support pcre2 for regex","priority":"suggested","soname":["libpcre2-8.so.0","libpcre2-8.so.1"]}]
  FDO                  0x0000008e	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"lz4","description":"Support lz4 decompression in journal and coredump files","priority":"recommended","soname":["liblz4.so.1"]}]
  FDO                  0x00000095	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"tpm","priority":"recommended","soname":["libtss2-mu.so.0"]}, {"feature":"tpm","priority":"recommended","soname":["libtss2-esys.so.0"]}]

With -O2:

Displaying notes found in: .note.dlopen
  Owner                Data size 	Description
  FDO                  0x00000095	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"tpm","priority":"recommended","soname":["libtss2-mu.so.0"]}, {"feature":"tpm","priority":"recommended","soname":["libtss2-esys.so.0"]}]
  FDO                  0x0000008e	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"lz4","description":"Support lz4 decompression in journal and coredump files","priority":"recommended","soname":["liblz4.so.1"]}]
  FDO                  0x00000084	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"pcre2","description":"Support pcre2 for regex","priority":"suggested","soname":["libpcre2-8.so.0","libpcre2-8.so.1"]}]
  FDO                  0x00000088	FDO_DLOPEN_METADATA
    Dlopen Metadata: [{"feature":"fido2","description":"Support fido2 for encryption and authentication.","priority":"required","soname":["libfido2.so.1"]}]

So the test fails if -O2 is the default as the order is different

Follow-up for c2d3548
Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@keszybz keszybz merged commit 465a4cd into systemd:main Oct 5, 2025
1 check passed
@bluca bluca deleted the test_opt branch October 5, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants