Repository navigation
Conversation
setup_e2e.login() printed the full argv, which includes --token-value and the token. It now prints the argv with the token replaced by ***; the command that runs is unchanged. A test checks the token is absent from the printed output and still passed to the login command. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
When the login command fails, check_call raises CalledProcessError carrying the full command line, so the traceback showed the token even though the printed command line was masked. login() now re-raises the error with the masked command line and drops the chained original. A test checks that the raised error and its cmd do not contain the token. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/e2e/setup_e2e.pyprinted the full login command line, including--token-valueand the token, into CI and local logs. It now prints the command with the token replaced by***. The command that runs is unchanged.online_tests.pyalready guards the same kind of print withsafe_to_print; this bringssetup_e2e.pyin line.If the login command fails,
check_callraisesCalledProcessErrorcarrying the same command line, so the traceback would have shown the token.login()now re-raises it with the masked command line and drops the chained original.Tests check that the token is absent from the printed output and from the error raised by a failed login, and that it is still passed to the login command.
🤖 Generated with Claude Code