Skip to content

Mask the token value when the e2e login helper prints its command line - #499

Open
jacalata wants to merge 2 commits into
developmentfrom
jac/fix-e2e-token-print
Open

jacalata wants to merge 2 commits into
developmentfrom
jac/fix-e2e-token-print

Conversation

@jacalata

@jacalata jacalata commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

tests/e2e/setup_e2e.py printed the full login command line, including --token-value and the token, into CI and local logs. It now prints the command with the token replaced by ***. The command that runs is unchanged.

online_tests.py already guards the same kind of print with safe_to_print; this brings setup_e2e.py in line.

If the login command fails, check_call raises CalledProcessError carrying the same command line, so the traceback would have shown the token. login() now re-raises it with the masked command line and drops the chained original.

Tests check that the token is absent from the printed output and from the error raised by a failed login, and that it is still passed to the login command.

🤖 Generated with Claude Code

setup_e2e.login() printed the full argv, which includes --token-value and the
token. It now prints the argv with the token replaced by ***; the command that
runs is unchanged. A test checks the token is absent from the printed output and
still passed to the login command.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py121212 0%
   _version.py111111 0%
   tabcmd.py151515 0%
   version.py1066 40%
tabcmd/commands
   commands.py101010 0%
   constants.py771515 81%
   server.py1351818 87%
tabcmd/commands/auth
   session.py4164646 89%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1701818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py702323 67%
   export_command.py1262121 83%
   get_url_command.py1274747 63%
   publish_command.py1341616 88%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py661818 73%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py1151414 88%
   create_users_command.py5999 85%
   delete_site_users_command.py4355 88%
   user_data.py2303030 87%
tabcmd/execution
   _version.py222 0%
   global_options.py15544 97%
   localize.py671111 84%
   logger_config.py7266 92%
   tabcmd_controller.py4077 82%
TOTAL307045785% 

When the login command fails, check_call raises CalledProcessError carrying
the full command line, so the traceback showed the token even though the
printed command line was masked. login() now re-raises the error with the
masked command line and drops the chained original. A test checks that the
raised error and its cmd do not contain the token.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 21:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants