Skip to content

Convert --timeout to a number before passing it to wait_for_job in refreshextracts - #500

Open
jacalata wants to merge 1 commit into
developmentfrom
jac/fix-refresh-timeout-coercion
Open

jacalata wants to merge 1 commit into
developmentfrom
jac/fix-refresh-timeout-coercion

Conversation

@jacalata

Copy link
Copy Markdown
Contributor

refreshextracts --synchronous --timeout 60 passed the timeout to TSC's wait_for_job as the string "60", which wait_for_job compares with elapsed seconds, so waiting with a timeout could raise a TypeError.

  • --timeout is now parsed with type=int, so a non-numeric value is rejected by argparse (exit 2). Before, the session code only warned about it. The option is global, so this applies to every command.
  • refreshextracts converts the value through Server._timeout_seconds (moved from create_site_users.py), which treats a missing or non-positive value as "wait indefinitely".
  • New tests/commands/test_refresh_extracts_command.py; the login parser test expects an int and covers a non-numeric value.

🤖 Generated with Claude Code

…freshextracts

--timeout is now parsed with type=int, so a non-numeric value is rejected by
argparse. refreshextracts also converts the value defensively and treats
missing or non-positive values as "wait indefinitely".

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py121212 0%
   _version.py111111 0%
   tabcmd.py151515 0%
   version.py1066 40%
tabcmd/commands
   commands.py101010 0%
   constants.py771515 81%
   server.py1421818 87%
tabcmd/commands/auth
   session.py4164646 89%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1701818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py702323 67%
   export_command.py1262121 83%
   get_url_command.py1274747 63%
   publish_command.py1341616 88%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py4855 90%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py661818 73%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py1081414 87%
   create_users_command.py5999 85%
   delete_site_users_command.py4355 88%
   user_data.py2303030 87%
tabcmd/execution
   _version.py222 0%
   global_options.py15544 97%
   localize.py671111 84%
   logger_config.py7266 92%
   tabcmd_controller.py4077 82%
TOTAL307045285% 

@jacalata jacalata mentioned this pull request Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants