Repository navigation
Conversation
…freshextracts --timeout is now parsed with type=int, so a non-numeric value is rejected by argparse. refreshextracts also converts the value defensively and treats missing or non-positive values as "wait indefinitely". Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refreshextracts --synchronous --timeout 60passed the timeout to TSC'swait_for_jobas the string"60", whichwait_for_jobcompares with elapsed seconds, so waiting with a timeout could raise aTypeError.--timeoutis now parsed withtype=int, so a non-numeric value is rejected by argparse (exit 2). Before, the session code only warned about it. The option is global, so this applies to every command.refreshextractsconverts the value throughServer._timeout_seconds(moved fromcreate_site_users.py), which treats a missing or non-positive value as "wait indefinitely".tests/commands/test_refresh_extracts_command.py; the login parser test expects an int and covers a non-numeric value.🤖 Generated with Claude Code