Skip to content

[sync] T4665 Fix link picker range selection after search#3224

Closed
tea-artist wants to merge 1 commit into
developfrom
sync/ee-20260523-102231
Closed

[sync] T4665 Fix link picker range selection after search#3224
tea-artist wants to merge 1 commit into
developfrom
sync/ee-20260523-102231

Conversation

@tea-artist
Copy link
Copy Markdown
Contributor

@tea-artist tea-artist commented May 23, 2026

🔄 Automated sync from EE repository.

54 commit(s) synced since last sync.

Authors

Included commits

  • T4665 Fix link picker range selection after search (nichenqin)
  • chore: add performace trace trigger T4666 (Bieber)
  • fix(app): tolerate nullable field options in editor (nichenqin)
  • fix(share): use status dot for table/view share state (T4669) (Aries X)
  • T4615 Fix link copy paste into text fields (nichenqin)
  • T4086 Avoid computed updates through unavailable tables T4086 (nichenqin)
  • fix(app): handle lookup field editor null options (nichenqin)
  • fix(v2): optimize conditional lookup field reference query (nichenqin)
  • fix: keep tables ready after update failures T4661 (nichenqin)
  • fix(selection-statistic): clarify copy feedback T4616 (Jun Lu)
  • fix: improve user filter dropdown T4390 (Jun Lu)
  • fix(T4609): add form view side gutter (Jun Lu)
  • feat(cross-space): forbid cross-space link/lookup/rollup across create, duplicate, move (T3837) (Aries X)
  • feat/automation history new layout (Jun Lu)
  • fix: chat queue force send render (Boris)
  • Add v2 full rollout admin workflow T3836 (nichenqin)
  • Enhance AI agent task progress and runtime context T4093 T4658 (Pengap)
  • T4357 fix: preserve computed filter before images (nichenqin)
  • feat(cli): base CRUD + command toggle + private-deploy (T4597, T4606) (Boris)
  • T4357 fix: reduce computed update storm (nichenqin)
  • fix(sdk): refresh grouped record queries after mutations (nichenqin)
  • fix(toolbar): prevent overlap on narrow widths T4148 (Jun Lu)
  • fix(t4595): enforce space owner limit only on free spaces (Uno)
  • T4594 Fix BYODB AI field generation without CLS context (nichenqin)
  • T4598 fix stale grouped grid cache (nichenqin)
  • fix(view): drop submit.allow flag, gate form-submit on view.type (T4612) (Aries X)
  • fix(v2): defer computed tasks for inactive tables (nichenqin)
  • fix(sdk): reconcile query changes for grid records (nichenqin)
  • fix(v2): fall back to async computed backfill (nichenqin)
  • fix(app): avoid redirecting to unavailable table nodes (nichenqin)
  • feat(T4591): update changelog banner (Jocky-Teable)
  • fix(v2): resolve fk repair targets from table meta (nichenqin)
  • T3769 Add v2 duplicate base streaming (nichenqin)
  • fix(v2): reduce record order query parameters T4456 (nichenqin)
  • feat(app): support existing space BYODB binding T4162 (nichenqin)
  • fix(app): share view redirected to login on open (T4490) (Aries X)
  • fix: chunk wide computed updates (nichenqin)
  • fix: optimize conditional rollup computed queries (nichenqin)
  • fix(v2): preserve table references on soft delete (nichenqin)
  • Enhance IM chat context understanding T4258 (Pengap)
  • chore: update system prompt T4192 (Bieber)
  • feat(backend): support v2 tea export T3699 (nichenqin)
  • fix(v2): enforce select choice name limits (nichenqin)
  • fix: repair missing-column v2 schema operations (nichenqin)
  • fix: persist chat input draft per chatId across refresh (T4142) (Aries X)
  • fix(core): normalize numeric formula field values (nichenqin)
  • feat: add BYODB space data database support T3766 (nichenqin)
  • feat(t4133): add admin notification feature with validation and service integration (Uno)
  • fix: scenario error cleanup consistency (Boris)
  • fix(v2): allow delete with duplicate linked field names (nichenqin)
  • fix: enforce v2 table data safety limits (T4130) (nichenqin)
  • fix: handle blank number formula output (T4128) (nichenqin)
  • feat(t4094): update changelog banner to @ Any Node in AI Chat (Jocky-Teable)
  • Improve AI generation flow reliability T4091 T4084 (Pengap)

Latest source commit: teableio/teable-ee@f9d43ca

This PR was automatically created by the sync workflow.

@github-actions @caoxing9
@tea-artist @boris-w @Jocky-Teable @hammond-lj @Pengap @younocode @nichenqin
[sync] T4665 Fix link picker range selection after search
db69b98 
Synced from teableio/teable-ee@f9d43ca

Co-authored-by: Aries X <caoxing9@gmail.com>
Co-authored-by: Bieber <artist@teable.io>
Co-authored-by: Boris <boris2code@outlook.com>
Co-authored-by: Jocky-Teable <jocky@teable.ai>
Co-authored-by: Jun Lu <hammond@teable.io>
Co-authored-by: Pengap <penganpingprivte@gmail.com>
Co-authored-by: Uno <uno@teable.ai>
Co-authored-by: nichenqin <nichenqin@hotmail.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 23, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db69b981dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/nextjs-app/src/lib/marketing-attribution.ts
Comment on lines +179 to +181
persistAttribution({
...storedAttribution?.value,
...enrichAttribution(currentAttribution),
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset stored UTM fields when a new touch is captured

If a user already has stored attribution and later lands with only a subset of parameters (for example just utm_source), this merge keeps stale keys from the previous campaign (such as an old utm_campaign) and only overwrites provided keys. That produces mixed, incorrect attribution payloads for analytics and downstream reporting; a new touch should replace prior campaign fields (while still re-enriching things like ga_client_id) instead of inheriting missing ones from storage.

Useful? React with 👍 / 👎.

Comment thread packages/sdk/src/components/editor/link/LinkListRangeQuery.ts
Comment on lines +38 to +39
groupBy,
collapsedGroupIds,
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid sending un-serialized group query params to range-to-id

This now forwards groupBy and collapsedGroupIds into the range-to-id request, but getIdsFromRanges in packages/openapi/src/selection/range.ts only JSON-serializes filter, orderBy, and ranges. In grouped link-picker scenarios, these complex params are sent in raw Axios query format and can fail validation/parsing on the rangesToIdQuerySchema endpoint, causing range selection to break when grouping is active.

Useful? React with 👍 / 👎.

@tea-artist tea-artist closed this May 23, 2026
@tea-artist tea-artist deleted the sync/ee-20260523-102231 branch May 23, 2026 11:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 23, 2026

🧹 Preview Environment Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tea-artist @CLAassistant