Skip to content

Call new ConnectionError with appropriate args#1811

Merged
dhensby merged 1 commit intotediousjs:masterfrom
gavinaiken:master
Mar 18, 2026
Merged

Call new ConnectionError with appropriate args#1811
dhensby merged 1 commit intotediousjs:masterfrom
gavinaiken:master

Conversation

@gavinaiken
Copy link
Contributor

What this does:

Calls new ConnectionError with the appropriate args

Before:

conn err: ConnectionError: [object Object]
    at PrivateConnection.callback2 (/Users/gavin/repos/node-core/collector/collector-server/node_modules/mssql/lib/msnodesqlv8/connection-pool.js:47:17)
    at Immediate._onImmediate (/Users/gavin/repos/node-core/collector/collector-server/node_modules/msnodesqlv8/lib/connection.js:47:14)
    at process.processImmediate (node:internal/timers:485:21) {
  code: undefined
}

After:

conn err: ConnectionError: [unixODBC][Driver Manager]Can't open lib 'ODBC Driver 17 for SQL Server' : file not found
    at PrivateConnection.callback2 (/Users/gavin/repos/node-core/collector/collector-server/node_modules/mssql/lib/msnodesqlv8/connection-pool.js:47:17)
    at Immediate._onImmediate (/Users/gavin/repos/node-core/collector/collector-server/node_modules/msnodesqlv8/lib/connection.js:47:14)
    at process.processImmediate (node:internal/timers:485:21) {
  code: 0
}

Related issues:

Resolves #1810

Pre/Post merge checklist:

  • Update change log

@dhensby dhensby merged commit ec4450f into tediousjs:master Mar 18, 2026
43 checks passed
@dhensby
Copy link
Collaborator

dhensby commented Mar 18, 2026

@gavinaiken - thanks for the patch; sorry it's taken so long to look at and get it! Hopefully the automatic releaser will get this published shortly!

@gavinaiken
Copy link
Contributor Author

No worries, thanks for merging!

@github-actions
Copy link

🎉 This PR is included in version 12.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in ConnectionError open do not provide details

2 participants