Open
Conversation
Contributor
Author
|
Requesting review from @benja who has experience with the following files modified in this PR:
|
![staging-tembo[bot]](https://avatars.githubusercontent.com/in/1455450?s=60&v=4){kind=small}
| { | ||
| "mcpServers": { | ||
| "my-server": { | ||
| "command": "npx", |
Contributor
There was a problem hiding this comment.
This example looks like the same stdio server shape shown in integrations/mcp.mdx, but it omits "type": "stdio". If the schemas are meant to match, adding it here would keep the docs consistent and avoid readers copying an incomplete config.
| "command": "npx", | ||
| "args": ["-y", "@modelcontextprotocol/server-github"], | ||
| "env": { | ||
| "GITHUB_TOKEN": "ghp_xxx" |
Contributor
There was a problem hiding this comment.
ghp_xxx looks like a real PAT prefix, which can trip secret scanners and encourage copy-pasting token-shaped values in docs.
Suggested change
| "GITHUB_TOKEN": "ghp_xxx" | |
| "GITHUB_TOKEN": "your-github-token" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added new documentation for model settings feature and expanded MCP integration docs:
features/model-settings.mdxdocumenting default agent selection, provider API keys, global MCP servers config, and available models managementdocs.jsonfeatures/automations.mdxlinking to model settings for workspace defaultsintegrations/mcp.mdxwith detailed custom server connection types (Remote HTTP/SSE and Stdio) including configuration examples