Add start delay field to StartActivityExecutionRequest#767
Merged
Conversation
b293829 to
30651e4
Compare
Sushisource
reviewed
Apr 22, 2026
30651e4 to
47fdfcd
Compare
Sushisource
approved these changes
Apr 23, 2026
dandavison
approved these changes
Apr 24, 2026
| repeated temporal.api.common.v1.Link links = 20; | ||
| // Options for handling conflicts when using ACTIVITY_ID_CONFLICT_POLICY_USE_EXISTING. | ||
| temporal.api.common.v1.OnConflictOptions on_conflict_options = 21; | ||
| // Time to wait before dispatching the activity. |
Contributor
There was a problem hiding this comment.
nit: this is a bit clearer to me and matches the language in the workflow start_delay comments.
Suggested change
| // Time to wait before dispatching the activity. | |
| // Time to wait before dispatching the first activity task. |
Contributor
Author
There was a problem hiding this comment.
I'm going to make a bit clearer. @Sushisource had previously mentioned the first sounded confusing.
// Time to wait before dispatching the activity. This delay is not applied to retry attempts.
LMK thoughts
Contributor
Author
There was a problem hiding this comment.
Per discussion Dan still prefers the task word. "So the more explicit/technical version made sense to me; for "activities" themselves, users are familiar with "starting" them, but even there there's confusion with "scheduling" , so I thought best not to add a 3rd verb"
spkane31
pushed a commit
that referenced
this pull request
Apr 24, 2026
**What changed?** Added a start_delay field to StartActivityExecutionRequest in the proto definition and updated the OpenAPI specs accordingly. **Why?** To allow callers to specify a delay before the first standalone activity task is dispatched, matching the existing start delay capability available for workflow-started activities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a start_delay field to StartActivityExecutionRequest in the proto definition and updated the OpenAPI specs accordingly.
Why?
To allow callers to specify a delay before the first standalone activity task is dispatched, matching the existing start delay capability available for workflow-started activities.