Skip to content

[don't merge] api changes for time-skipping propagation#770

Open
feiyang3cat wants to merge 2 commits intomasterfrom
api-ts-patch-2
Open

[don't merge] api changes for time-skipping propagation#770
feiyang3cat wants to merge 2 commits intomasterfrom
api-ts-patch-2

Conversation

@feiyang3cat
Copy link
Copy Markdown
Contributor

@feiyang3cat feiyang3cat commented Apr 22, 2026

What changed and why?

Propagation refers to how time-skipping config is carried over to all workflows started by the current workflow: retry, continue-as-new, child workflows, reset, etc.

  1. Remove disable_propagation and max_target_time, as neither can be accurately defined when time-skipping propagates transitively across related workflows:
  • max_target_time: as an absolute time point, it may already have passed by the time a retry or downstream workflow starts, making it ambiguous whether to disable or preserve time-skipping — neither is a clearly correct default
  • disable_propagation: it is unclear which type of transitively triggered workflow this should apply to, and treating all cases uniformly is unreasonable; we defer exposing this flexibility until user demand and use cases are better understood
  1. Add comments documenting the default propagation behavior for each feature (retry, continue-as-new, child workflow, reset)
  2. Add comments to explain bound
  3. Add propagated skipped duration to time skipping config so that new workflows can inherit the virtual time

@feiyang3cat feiyang3cat requested review from a team April 22, 2026 21:23
@@ -590,28 +590,28 @@ message WorkflowExecutionOptions {
// User timers are not classified as in-flight work and will be skipped over.
// When time advances, it skips to the earlier of the next user timer or the configured bound, if either exists.
message TimeSkippingConfig {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed
but buf-breaking step in Makefile:115-117 will stop doing so

and add propagated_skipped_duration to propagate virtual time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant