[don't merge] api changes for time-skipping propagation#770
Open
feiyang3cat wants to merge 2 commits intomasterfrom
Open
[don't merge] api changes for time-skipping propagation#770feiyang3cat wants to merge 2 commits intomasterfrom
feiyang3cat wants to merge 2 commits intomasterfrom
Conversation
bcf6ece to
be3ff37
Compare
feiyang3cat
commented
Apr 22, 2026
| @@ -590,28 +590,28 @@ message WorkflowExecutionOptions { | |||
| // User timers are not classified as in-flight work and will be skipped over. | |||
| // When time advances, it skips to the earlier of the next user timer or the configured bound, if either exists. | |||
| message TimeSkippingConfig { | |||
Contributor
Author
There was a problem hiding this comment.
can be removed
but buf-breaking step in Makefile:115-117 will stop doing so
and add propagated_skipped_duration to propagate virtual time
be3ff37 to
27475f8
Compare
d5b3984 to
b9d4b1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why?
Propagation refers to how time-skipping config is carried over to all workflows started by the current workflow: retry, continue-as-new, child workflows, reset, etc.