plugins-guide: concrete patterns for duplicate-side-effect testing#4481
Open
donald-pinckney wants to merge 1 commit intomainfrom
Open
plugins-guide: concrete patterns for duplicate-side-effect testing#4481donald-pinckney wants to merge 1 commit intomainfrom
donald-pinckney wants to merge 1 commit intomainfrom
Conversation
The previous text ("Check for duplicate side effects or other types of
failures") did not give readers enough to act on. Retrying activities
can cause a simple execution counter to flake even when the plugin is
correct, so replace the vague line with two patterns that are invariant
under activity-task retries: counting ActivityTaskScheduled events in
history, or accumulating activity IDs in a set.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
donald-pinckney
requested review from
drewhoskins-temporal,
mjameswh and
tconley1428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
┆Attachments: EDU-6259 plugins-guide: concrete patterns for duplicate-side-effect testing