Skip to content

💥 Use ExternalStorageReference protobuf message for payload references#1486

Merged
jmaeagle99 merged 1 commit intotemporalio:mainfrom
jmaeagle99:storage-ref-proto
Apr 29, 2026
Merged

💥 Use ExternalStorageReference protobuf message for payload references#1486
jmaeagle99 merged 1 commit intotemporalio:mainfrom
jmaeagle99:storage-ref-proto

Conversation

@jmaeagle99
Copy link
Copy Markdown
Contributor

@jmaeagle99 jmaeagle99 commented Apr 27, 2026

What was changed

  • Store and retrieve payload references as ExternalStorageReference protobuf message encoded with protojson.
  • Allow backward compatible retrieval of prerelease plain json encoding.

💥 Breaking Change

Workflow history that contains an external storage reference that is encoded using the proto-JSON converter will likely not be runnable on workers using prior versions of the SDK due to this format change.

Why?

  • Standardize on protobuf message for encoding storage references.

Checklist

  1. How was this tested: Existing tests, compat tests, and new tests
  2. Any docs updates needed? No

@jmaeagle99 jmaeagle99 changed the title Replace _StorageReference with ExternalStorageReference proto Use ExternalStorageReference protobuf message for payload references Apr 27, 2026
@jmaeagle99 jmaeagle99 force-pushed the storage-ref-proto branch 5 times, most recently from bc43d80 to 3bc3d60 Compare April 28, 2026 22:14
@jmaeagle99 jmaeagle99 changed the title Use ExternalStorageReference protobuf message for payload references 💥 Use ExternalStorageReference protobuf message for payload references Apr 28, 2026
@jmaeagle99 jmaeagle99 marked this pull request as ready for review April 28, 2026 22:50
@jmaeagle99 jmaeagle99 requested a review from a team as a code owner April 28, 2026 22:50
Comment thread temporalio/converter/_extstore.py
Comment thread temporalio/converter/_extstore.py
@jmaeagle99 jmaeagle99 merged commit 8a6d0e0 into temporalio:main Apr 29, 2026
17 checks passed
@jmaeagle99 jmaeagle99 deleted the storage-ref-proto branch April 29, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants