fix(wallet): report unavailable balances and RPC failures - #138
Merged
Conversation
brendanjryan
force-pushed
the
fix/mpp-wallet-readiness
branch
from
September 9, 2026 17:20
7efd640 to
d3c0120
Compare
Report failed balance queries as null instead of zero, include RPC diagnostics in whoami and key output, and mark readiness false when the balance cannot be queried. Preserve configured wallet/key details and locally recorded session reserves; a successful zero-balance query remains distinct from an RPC failure. Update output schemas, CLI metadata and documentation to describe nullable balances and the diagnostic fields.
brendanjryan
force-pushed
the
fix/mpp-wallet-readiness
branch
from
September 9, 2026 17:24
d3c0120 to
4827707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report unavailable balances as
nullinstead of zero and include RPC diagnostics in wallet and key output.whoaminow reportsready: falsewhen its balance query fails while retaining wallet/key details and locally recorded session reserves.Update schemas and documentation to distinguish RPC failures from successful zero-balance queries.
Validation: 177 tests passed, including actual CLI coverage, plus typechecks, lint, formatting and changelog validation.
AI-assisted