Skip to content

fix: use subprocess instead of os.system in... #13640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use subprocess instead of os.system in... #13640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions research/cognitive_planning/viz_active_vision_dataset_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@
import tensorflow as tf
from matplotlib import pyplot as plt
import numpy as np
import glob
import os
from PIL import Image
from pyglib import app
from pyglib import flags
import gin
Expand Down Expand Up @@ -266,12 +268,13 @@ def which_goal(file_name):
cv2.imwrite(os.path.join(output_folder, '{0:03d}'.format(j) + '.jpg'),
img[:, :, ::-1])
print 'converting to gif'
os.system(
'convert -set delay 20 -colors 256 -dispose 1 {}/*.jpg {}.gif'.format(
output_folder,
os.path.join(output_gifs_folder, pure_name + '.gif')
)
)
jpg_files = sorted(glob.glob(os.path.join(output_folder, '*.jpg')))
gif_output = os.path.join(output_gifs_folder, pure_name + '.gif')
pil_frames = [Image.open(f) for f in jpg_files]
if pil_frames:
pil_frames[0].save(
gif_output, save_all=True, append_images=pil_frames[1:],
loop=0, duration=20)

def evaluate_folder(env, folder_path):
"""Evaluates the performance from the evals folder."""
Expand Down