fix: use subprocess instead of os.system in dataset_download.py#13641
Open
orbisai0security wants to merge 1 commit intotensorflow:masterfrom
Open
fix: use subprocess instead of os.system in dataset_download.py#13641orbisai0security wants to merge 1 commit intotensorflow:masterfrom
orbisai0security wants to merge 1 commit intotensorflow:masterfrom
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
research/delf/delf/python/datasets/sfm120k/dataset_download.py.Vulnerability
V-007research/delf/delf/python/datasets/sfm120k/dataset_download.py:54Description: The dataset_download.py script extracts downloaded tar archives using os.system() with the tar command, without validating archive member paths before extraction. A malicious tar archive can contain entries with path traversal sequences (e.g., ../../etc/cron.d/backdoor) that cause tar to write files outside the intended destination directory. This 'Tar Slip' vulnerability allows an attacker who can serve a malicious archive (via a compromised CDN, DNS hijacking, or man-in-the-middle attack) to write arbitrary files anywhere on the host filesystem accessible to the running process.
Changes
research/delf/delf/python/datasets/sfm120k/dataset_download.pyVerification
Automated security fix by OrbisAI Security