Adds opt-in log capture via withLogCapture() and getCapturedLogs().#11431
Open
VolkovIO wants to merge 1 commit intotestcontainers:mainfrom
Open
Adds opt-in log capture via withLogCapture() and getCapturedLogs().#11431VolkovIO wants to merge 1 commit intotestcontainers:mainfrom
VolkovIO wants to merge 1 commit intotestcontainers:mainfrom
Conversation
This allows retrieving container output even when startup fails or the container exits quickly, where getLogs() may return empty output. Fixes testcontainers#11215"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenericContainer.getLogs()can return empty output when container startup fails or the container exits very quickly (e.g. one-shot commands). This PR adds an opt-in mechanism to capture container logs in memory so they can still be retrieved after a failed start.Changes
withLogCapture()to enable in-memory log capture (disabled by default).getCapturedLogs()to retrieve captured stdout/stderr.Rationale
The implementation reuses the existing log consumer mechanism by registering a
ToStringConsumerwhen log capture is enabled, without changing default behavior orgetLogs()semantics.Testing
GenericContainerLogCaptureTestverifies:withLogCapture()is enabledFixes #11215