Fix host UID/GID leakage in copyFileToContainer TAR entries#11488
Open
ym0506 wants to merge 1 commit intotestcontainers:mainfrom
Open
Fix host UID/GID leakage in copyFileToContainer TAR entries#11488ym0506 wants to merge 1 commit intotestcontainers:mainfrom
ym0506 wants to merge 1 commit intotestcontainers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11487
Problem
When
copyFileToContainercopies aMountableFile, TAR entries are created from host files. The TAR metadata may carry host UID/GID values into the container.On rootless Docker setups, those IDs may be unmapped, causing permission/ownership issues (e.g. Keycloak dev service failing to read copied config).
Solution
Normalize TAR entry ownership for
MountableFilecopies:uid=0gid=0This avoids leaking host identity into the container filesystem metadata.
Tests
Added
MountableFileTest#tarEntriesShouldUseRootOwnershipto verify generated TAR entries use UID/GID 0.Related