Add MinIO container implementation under org.testcontainers.minio - #11949
Open
khalilswdp wants to merge 1 commit into
Open
Add MinIO container implementation under org.testcontainers.minio#11949khalilswdp wants to merge 1 commit into
khalilswdp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the ongoing package migration by adding a MinIO container implementation
under
org.testcontainers.minio, following the same approach as the Solr (#11104)and Cassandra (#8616) migrations.
Changes
org.testcontainers.minio.MinIOContainerwith an API identical to theexisting class (constructors,
withUserName,withPassword,getS3URL,credential getters).
org.testcontainers.containers.MinIOContainervia a@deprecatedjavadoc tag pointing to the new class. The deprecated class is otherwise
untouched, so existing users are unaffected apart from a compile-time
deprecation warning.
MinIOContainerTesttoorg.testcontainers.minioso the documentationsnippets (codeinclude blocks) demonstrate the new package.
docs/modules/minio.mdaccordingly.Notes
differing only in package declaration and an explicit
GenericContainerimport.org.testcontainers.containers.MinIOContainer→org.testcontainers.minio.MinIOContainer../gradlew :testcontainers-minio:checkstyleMain :testcontainers-minio:checkstyleTest :testcontainers-minio:spotlessApplypasses, and the module tests were runlocally against Docker.