Remove obsolete Docker version startup check - #11951
Open
khalilswdp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the startup check that asserts the Docker server version is at least 1.6.0.
Docker 1.6.0 was released in 2015, and every daemon the modern client libraries can
connect to is far past it, so the check can never fail in practice — it only adds a
version parse and log output to every first container start.
Changes
checkDockerVersionand the now-unused privatecheckhelper fromDockerClientFactory, along with the surrounding checks block inclient().Both methods were private, so there is no public API impact.
docs/features/configuration.md.Notes
checks.disableconfiguration property is intentionally left in place: it isstill consumed elsewhere (
ContainerDef), and whether to deprecate it is left asa follow-up decision.
"A port exposed by a docker container should be accessible") describe checks that
were removed some time ago; happy to rewrite that docs section here or in a
follow-up, whichever is preferred.