Make container port mapping timeout configurable - #11952
Closed
khalilswdp wants to merge 1 commit into
Closed
Conversation
Member
|
Closing. See #11938 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During container startup,
GenericContainerpollsinspectContaineruntil the Dockerdaemon reports all exposed ports as mapped, with a hard-coded 5-second limit. On heavily
loaded hosts (shared CI runners in particular) the daemon can take longer, and the
resulting failure is an opaque Awaitility timeout rather than the detailed diagnostics
produced for later startup failures.
Changes
container.port.mapping.timeoutconfiguration property (default: 5 seconds, soout-of-the-box behavior is unchanged), read via the standard mechanism — env var
TESTCONTAINERS_CONTAINER_PORT_MAPPING_TIMEOUT,~/.testcontainers.properties, or aclasspath
testcontainers.properties.GenericContainer.tryStart()in place of the hard-coded value.docs/features/configuration.mdand cover thedefault/property/env-var precedence in
TestcontainersConfigurationTest.A configuration property (rather than a per-container API) was chosen deliberately: the
latency this timeout absorbs is a characteristic of the Docker daemon and host load, not
of any particular container, mirroring existing environment-level knobs such as
client.ping.timeout.