Skip to content

Reject repeated SHA-256 digests in DockerImageName #12155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wozhenbang2004 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Reject repeated SHA-256 digests in DockerImageName #12155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94f58e9
Reject repeated image digests
wozhenbang2004 Nov 5, 2026
0872613
Cover repeated digest image references
wozhenbang2004 Nov 5, 2026
b9d639d
Cover trailing image digest delimiters
wozhenbang2004 Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions core/src/main/java/org/testcontainers/utility/DockerImageName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,19 @@ public DockerImageName(String fullImageName) {
}

if (remoteName.contains("@sha256:")) {
String beforeDigest = remoteName.split("@sha256:")[0];
String[] nameAndDigest = remoteName.split("@sha256:", 3);
if (nameAndDigest.length != 2 || nameAndDigest[1].isEmpty()) {
throw new IllegalArgumentException("Invalid SHA-256 digest in Docker image name: " + fullImageName);
}
String beforeDigest = nameAndDigest[0];
String digest = nameAndDigest[1];
if (beforeDigest.contains(":")) {
repository = beforeDigest.split(":")[0];
String tag = beforeDigest.split(":", 2)[1];
versioning = new Sha256Versioning(remoteName.split("@sha256:")[1], tag);
versioning = new Sha256Versioning(digest, tag);
} else {
repository = beforeDigest;
versioning = new Sha256Versioning(remoteName.split("@sha256:")[1]);
versioning = new Sha256Versioning(digest);
}
} else if (remoteName.contains(":")) {
repository = remoteName.split(":")[0];
Expand Down
11 changes: 11 additions & 0 deletions core/src/test/java/org/testcontainers/utility/DockerImageNameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import org.junit.jupiter.params.provider.ValueSource;

import java.util.stream.Stream;

Expand Down Expand Up @@ -60,6 +61,16 @@ void testInvalidNameRejected(String imageName) {
assertThatThrownBy(() -> DockerImageName.parse(imageName).assertValid())
.isInstanceOf(IllegalArgumentException.class);
}

@ParameterizedTest
@ValueSource(strings = { "", "1234abcd1234abcd1234abcd1234abcd" })
void rejectsRepeatedDigestWhenParsing(String secondDigest) {
String digestSuffix = "@sha256:1234abcd1234abcd1234abcd1234abcd@sha256:" + secondDigest;
assertThatThrownBy(() -> DockerImageName.parse("myname" + digestSuffix))
.isInstanceOf(IllegalArgumentException.class);
assertThatThrownBy(() -> DockerImageName.parse("myname:latest" + digestSuffix))
.isInstanceOf(IllegalArgumentException.class);
}
}

@Nested
Expand Down
Loading