Skip to content

fix(sftp): Avoid using wait_for_logs in module. #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderankin merged 2 commits into from
Apr 1, 2026
+3 −2
Merged

fix(sftp): Avoid using wait_for_logs in module. #995

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43ca414
fix(sftp): Avoid using wait_for_logs in module.
Apr 1, 2026
3d7b3c9
Execute start() after setting strategy.
Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modules/sftp/testcontainers/sftp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from cryptography.hazmat.primitives.asymmetric import rsa

from testcontainers.core.container import DockerContainer
from testcontainers.core.waiting_utils import wait_for_logs
from testcontainers.core.wait_strategies import LogMessageWaitStrategy

if TYPE_CHECKING:
from typing_extensions import Self
Expand Down Expand Up @@ -265,8 +265,9 @@ def _configure(self) -> None:
self.with_exposed_ports(self.port)

def start(self) -> Self:
strategy = LogMessageWaitStrategy(f".*Server listening on 0.0.0.0 port {self.port}.*")
self.waiting_for(strategy)
super().start()
wait_for_logs(self, f".*Server listening on 0.0.0.0 port {self.port}.*")
return self

def get_exposed_sftp_port(self) -> int:
Expand Down
Loading