Repository navigation
Fix/navbar mega menu mobile - #1694
ashutoshpalhare wants to merge 3 commits into
Conversation
|
@ashutoshpalhare is attempting to deploy a commit to the Bergside Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 0af4af2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughNavbarLink now keeps the mobile navbar collapse open when a nested interactive element is clicked. The change adds an interaction test and a patch changeset. ChangesNavbar click handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Nested button clicks now keep the mobile navbar open as intended, while ordinary link clicks retain their dismissal behavior. No issue requiring action before merge was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
packages/ui/src/components/Navbar/Navbar.test.tsxOops! Something went wrong! :( ESLint: 8.57.0 Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Failed to load plugin 'tailwindcss' declared in '--config': Package subpath './resolveConfig' is not defined by "exports" in /.eslint-tmp/node_modules/tailwindcss/package.json packages/ui/src/components/Navbar/NavbarLink.tsxESLint skipped: the matched ESLint configuration already failed (plugin-compatibility). Warning Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summarize the changes made and the motivation behind them.
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.
Summary by CodeRabbit