Skip to content

Fix/navbar mega menu mobile - #1694

Open
ashutoshpalhare wants to merge 3 commits into
themesberg:mainfrom
ashutoshpalhare:fix/navbar-mega-menu-mobile
Open

ashutoshpalhare wants to merge 3 commits into
themesberg:mainfrom
ashutoshpalhare:fix/navbar-mega-menu-mobile

Conversation

@ashutoshpalhare

@ashutoshpalhare ashutoshpalhare commented Oct 5, 2026 •

Copy link
Copy Markdown

Summarize the changes made and the motivation behind them.

Reference related issues using # followed by the issue number.

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed mobile navigation collapsing when clicking a nested button or other interactive element.

@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

@ashutoshpalhare is attempting to deploy a commit to the Bergside Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0af4af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
flowbite-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5e3541c4-8df0-43ae-bbf7-0deac6cb1981
📥 Commits

Reviewing files that changed from the base of the PR and between 85319bd and 0af4af2.

📒 Files selected for processing (3)
  • .changeset/quiet-walls-click.md
  • packages/ui/src/components/Navbar/Navbar.test.tsx
  • packages/ui/src/components/Navbar/NavbarLink.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

NavbarLink now keeps the mobile navbar collapse open when a nested interactive element is clicked. The change adds an interaction test and a patch changeset.

Changes

Navbar click handling

Layer / File(s) Summary
Preserve collapse for nested clicks
packages/ui/src/components/Navbar/NavbarLink.tsx, packages/ui/src/components/Navbar/Navbar.test.tsx, .changeset/quiet-walls-click.md
NavbarLink detects clicks inside nested interactive elements and calls onClick without closing the collapse. The test checks that a nested button click leaves the collapse visible. The changeset records a patch.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0af4a

Nested button clicks now keep the mobile navbar open as intended, while ordinary link clicks retain their dismissal behavior. No issue requiring action before merge was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies a mobile navbar fix, which relates to the changes, but it does not specify that nested interactive clicks keep the navbar open.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/ui/src/components/Navbar/Navbar.test.tsx

Oops! Something went wrong! :(

ESLint: 8.57.0

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Failed to load plugin 'tailwindcss' declared in '--config': Package subpath './resolveConfig' is not defined by "exports" in /.eslint-tmp/node_modules/tailwindcss/package.json
Referenced from: /packages/ui/.eslintrc.cjs
at exportsNotFound (node:internal/modules/esm/resolve:310:10)
at packageExportsResolve (node:internal/modules/esm/resolve:658:9)
at resolveExports (node:internal/modules/cjs/loader:685:36)
at Module._findPath (node:internal/modules/cjs/loader:752:31)
at Module._resolveFilename (node:internal/modules/cjs/loader:1461:27)
at wrapResolveFilename (node:internal/modules/cjs/loader:1049:27)
at defaultResolveImplForCJSLoading (node:internal/modules/cjs/loader:1073:10)
at defaultResolve (node:internal/modules/cjs/loader:1124:20)
at nextStep (node:internal/modules/customization_hooks:189:26)
at resolve (file:///.eslint-tmp/.coderabbit-resolver.mjs:11:14)

packages/ui/src/components/Navbar/NavbarLink.tsx

ESLint skipped: the matched ESLint configuration already failed (plugin-compatibility).

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant