Open
Conversation
Owner
|
In general I got no objection .. .let's merge the tests PR first though. Also make sure that prettier + prettier fix each get a script in the package.json |
Collaborator
Author
|
Yup, makes sense. You can use |
0595131 to
18795e5
Compare
Collaborator
Author
|
Rebased this PR on top of master to resolve conflicts in package.json, added I think this is ready for review/approval now! |
Owner
|
Hey sorry for the late reply (again). Thanks for rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @thlorenz 👋
I noticed in another PR there were some comments about formatting. I'm also looking at contributing to deoptigate and thought contributing may be easier if this repo used Prettier, since it appears you use it some of your other repos. Personally I use semis 😬 so it would at least automatically remove them for me if I accidentally add them.
I copied the prettier config from one of your other repos to hopefully maintain consistency with your preferred style. It looks like most of the changes are line-length changes and moving commas from the beginning of the line to the end of the line.
No pressure though if you think Prettier isn't right for this repo. Just thought I'd ask. I can always manually remove my semis in future PRs 😄