Skip to content

[Automated] Update newman CLI Options#2440

Open
thomhurst wants to merge 1 commit intomainfrom
automated/update-cli-options-newman
Open

[Automated] Update newman CLI Options#2440
thomhurst wants to merge 1 commit intomainfrom
automated/update-cli-options-newman

Conversation

@thomhurst
Copy link
Owner

Summary

This PR contains automatically generated updates to newman CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Mar 1, 2026
@thomhurst thomhurst enabled auto-merge (squash) March 1, 2026 03:17
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a minimal automated update PR — the sole change is a timestamp bump in .

What Changed


-[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-02-22T03:13:01.0642949Z")]
+[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-03-01T03:16:22.0239443Z")]

The generator re-ran and updated the timestamp, but found no actual changes to the newman CLI options — no new commands, no removed commands, no changed option types or descriptions.

Assessment

This PR is safe to merge as-is. The only change is the "GeneratedAt" timestamp, which is expected behaviour from the automated generator when the underlying CLI tool hasn't changed between runs. This confirms the generator is working correctly and newman's CLI interface remains stable.

Minor Observation

The PR description states "Added new commands if any were detected" and "Updated option types and descriptions", but the actual diff shows only the timestamp changed. The templated PR description can be slightly misleading for reviewers in cases like this where the CLI tool had no real changes. It would be clearer if the description dynamically reflected whether substantive options changes were detected (or explicitly noted "No option changes detected — timestamp updated only"). That said, this is a cosmetic issue with the PR template, not a code correctness concern.

Overall: LGTM. Safe to merge.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a minimal automated update PR — the sole change is a timestamp bump in AssemblyInfo.Generated.cs.

What Changed

The generator re-ran and updated the ModularPipelines.OptionsGenerator.GeneratedAt assembly metadata timestamp from 2026-02-22T03:13:01 to 2026-03-01T03:16:22, but found no actual changes to the newman CLI options — no new commands, no removed commands, no changed option types or descriptions.

Assessment

This PR is safe to merge as-is. The only change is the "GeneratedAt" timestamp, which is expected behaviour from the automated generator when the underlying CLI tool has not changed between runs. This confirms the generator is working correctly and newman's CLI interface remains stable.

Minor Observation

The PR description says "Added new commands if any were detected" and "Updated option types and descriptions", but the actual diff shows only the timestamp changed. The templated PR description can be slightly misleading for reviewers in cases like this where the CLI tool had no real changes. It would be clearer if the generator either skipped creating a PR entirely when no substantive changes are detected, or dynamically noted "No option changes detected — timestamp updated only" in the PR body. That said, this is a cosmetic issue with the PR template, not a code correctness concern.

Overall: LGTM. Safe to merge.

@thomhurst thomhurst force-pushed the automated/update-cli-options-newman branch from 571ef3e to 751e8af Compare March 8, 2026 03:10
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is another minimal automated update PR, consistent with the pattern observed in previous reviews.

What Changed

src/ModularPipelines.Newman/AssemblyInfo.Generated.cs

-[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-03-01T03:16:22.0239443Z")]
+[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-03-08T03:09:07.7636125Z")]

Only the GeneratedAt timestamp changed — again no substantive changes to newman CLI options were detected.

Assessment

This PR is safe to merge. The timestamp bump confirms the generator ran successfully on 2026-03-08 and found newman's CLI interface unchanged from the previous run (2026-03-01). This is expected, routine behaviour.

Carried-Over Observation (Unaddressed)

Previous reviews flagged that the PR description template is slightly misleading when no actual option changes are detected — it still says "Added new commands if any were detected" and "Updated option types and descriptions". This remains unaddressed. While it's a cosmetic issue, it adds noise for reviewers trying to understand the real scope of the change. The generator could either:

  • Skip opening a PR entirely when the only diff is the timestamp, or
  • Dynamically set the PR body to indicate "No option changes detected — timestamp updated only"

This is a low-priority improvement but worth addressing to reduce reviewer confusion over time.

Overall: LGTM. Safe to merge.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is the fourth consecutive automated PR for newman that contains only a timestamp bump — no actual CLI option changes were detected.

What Changed

src/ModularPipelines.Newman/AssemblyInfo.Generated.cs

-[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-03-08T03:09:07.7636125Z")]
+[assembly: AssemblyMetadata("ModularPipelines.OptionsGenerator.GeneratedAt", "2026-03-15T03:13:31.7712539Z")]

Only the GeneratedAt timestamp changed. Newman's CLI interface remains unchanged.

Repeated Unaddressed Observation

Previous reviews on 2026-03-01 and 2026-03-08 both raised the same concern: the automated generator opens a PR even when the only diff is a timestamp update, producing reviewer noise and wasted CI cycles. This has now gone unaddressed across three review cycles.

The core issue is an architectural one in the generator workflow: the generator should compare the substantive generated content against the existing content before deciding whether to open a PR. A timestamp is not a meaningful change to the options API surface, and opening a PR solely for it provides no value.

Concrete options to address this:

  1. Skip the PR entirely when the only delta is the GeneratedAt timestamp. The generator already knows what it generated — it can diff the options class files before invoking the PR-creation step.
  2. Separate the timestamp from the versioned content — store it in a file that is explicitly excluded from PR-creation logic, so it does not trigger a PR on its own.
  3. Gate PR creation on substantive changes — check git diff -- '*.Generated.cs' ':!*AssemblyInfo*' (or equivalent) and only create a PR if that diff is non-empty.

Any of these approaches would eliminate the recurring noise while still ensuring real option changes are surfaced promptly.

Assessment

Safe to merge as-is. Newman's CLI interface is stable. However, given this is the fourth identical review comment without action, it may be worth prioritising the generator improvement to avoid this becoming an indefinite weekly occurrence.

Overall: LGTM for merging, but the generator workflow improvement is now overdue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant