Skip to content

[Automated] Update flux CLI Options#2455

Open
thomhurst wants to merge 1 commit intomainfrom
automated/update-cli-options-flux
Open

[Automated] Update flux CLI Options#2455
thomhurst wants to merge 1 commit intomainfrom
automated/update-cli-options-flux

Conversation

@thomhurst
Copy link
Owner

Summary

This PR contains automatically generated updates to flux CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Mar 15, 2026
@thomhurst thomhurst enabled auto-merge (squash) March 15, 2026 03:14
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: [Automated] Update flux CLI Options

This is a straightforward automated PR with minimal changes — two modified files, 5 additions, 5 deletions. No prior review comments exist to follow up on.

What Changed

AssemblyInfo.Generated.cs: The GeneratedAt timestamp was updated from 2026-03-08T03:08:56.8911964Z to 2026-03-15T03:13:24.5806987Z. This is expected and correct — it reflects that the generator was re-run on a newer date.

FluxBootstrapGitlabVisibility.Generated.cs: The enum member ordering changed:

Before:

Internal, Private, Public

After:

Private, Public, Internal

Assessment

Correctness: The change is correct with respect to the Flux CLI. The --visibility flag for flux bootstrap gitlab accepts private, public, and internal as valid values. All three values remain present; only their order within the enum changed. No values were added or removed.

Breaking change risk: Enum member order in C# does not affect the underlying integer values assigned to members unless explicit integer assignments are used (none are here). Since no explicit values are assigned, all three members will still receive sequential default values (0, 1, 2), but the mapping between names and integers shifts:

Member Before After
Internal 0 2
Private 1 0
Public 2 1

This is a potentially breaking change if any consuming code stores or compares the raw integer value (e.g., serializes/deserializes the enum as an integer, or uses (int)FluxBootstrapGitlabVisibility.Private == 1 style comparisons). However, since this library uses [Description] attributes to map enum values to CLI flag strings, and the enum members are named identically, any code that works exclusively with named enum members (FluxBootstrapGitlabVisibility.Private) is unaffected. This is the expected and idiomatic usage pattern in this codebase.

Observation for the generator: The reordering appears to reflect a change in the order Flux CLI outputs the visibility options in its --help text. The generator faithfully mirrors that order, which is consistent with the project's design. That said, it may be worth considering whether the generator should sort enum members alphabetically or by some stable criterion to avoid spurious diffs in future PRs when CLIs reorder their help text without actually adding or removing options. This is a minor suggestion for the generator, not a blocker for this PR.

Verdict

The changes are mechanically correct and safe for the intended use pattern. The auto-merge configuration is appropriate for automated dependency/update PRs of this nature. Approving with the minor observation above noted for future generator consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant