Update dependency-updates (master) (patch) - #5099
Conversation
5d4f24d to
3698d8c
Compare
3698d8c to
6a37403
Compare
|
Removing "merge-when-ready" label due to new commits |
6a37403 to
4e4ed2a
Compare
|
Removing "merge-when-ready" label due to new commits |
16f7041 to
aad73cc
Compare
a5554ff to
f8e8576
Compare
90f49ca to
da0e21b
Compare
ℹ️ Artifact update noticeFile name: api/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
6c80395 to
6b2b0dc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Makefile:107
- K8S_VERSION is still set to v1.37.0-beta.0, but this PR bumps the Kubernetes Go modules to v0.37.0-rc.1. Since GO_BUILD_VER (and thus the calico/go-build image tag) is derived from K8S_VERSION, leaving this at beta.0 makes the toolchain versioning inconsistent with the updated dependencies and the comment that K8S_VERSION is used for dependencies/tests.
GO_VERSION?=1.26.7
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
561e1a8 to
87c401c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Makefile:107
go.modwas bumped to Kubernetes module versionsv0.37.0-rc.1, but the Makefile still pinsK8S_VERSIONtov1.37.0-beta.0(used to build thecalico/go-buildtag and described as the version for dependencies/tests/kubectl). This leaves the toolchain K8s version out of sync with the libraries and can result in pulling beta Kubernetes tooling while compiling against rc.1 APIs.
K8S_VERSION?=v1.37.0-beta.0
87c401c to
43bfe2a
Compare
| # The project Go version. | ||
| GO_VERSION?=1.26.5 | ||
| GO_VERSION?=1.26.7 | ||
| # Version of Kubernetes to use for dependencies, tests, and kubectl. |
43bfe2a to
5135006
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Makefile:107
K8S_VERSIONis still set tov1.37.0-beta.0even though Go module deps were bumped to the stablek8s.io/* v0.37.0series, and the comment suggests this value drives “dependencies, tests, and kubectl” (it appears to be used only for the go-build image tag viaGO_BUILD_VER). Keeping the beta suffix also prevents Renovate’s existingK8S_VERSIONregex (inrenovate.json) from matching and updating this value automatically.
GO_VERSION?=1.26.7
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
5135006 to
70cea03
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Makefile:107
- K8S_VERSION is still set to v1.37.0-beta.0 while this PR updates the Kubernetes Go modules from v0.37.0-beta.0 to v0.37.0. Since K8S_VERSION is documented as controlling dependency/test/kubectl versions, leaving it on a beta release makes the toolchain inconsistent with the now-stable dependency set.
GO_VERSION?=1.26.7
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
70cea03 to
ab2edaa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Suppressed comments (1)
Makefile:109
K8S_VERSIONis still set tov1.37.0-beta.0even though this PR updates the Go Kubernetes dependencies tov0.37.0(stable). SinceK8S_VERSIONis used to build the go-build image tag, this can leave the toolchain image version out of sync with the dependency set; consider updating it to a stablev1.37.0(or documenting why a beta tag is still required).
GO_VERSION?=1.26.7
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
# The version of LLVM to use for the go-build image.
LLVM_VERSION?=21.1.8
| k8s.io/cli-runtime v0.36.4 // indirect | ||
| k8s.io/component-base v0.37.0 // indirect | ||
| k8s.io/klog/v2 v2.140.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260706235625-cdb1db5517a0 // indirect | ||
| k8s.io/kubectl v0.36.2 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260721132016-d427ff9ee9ad // indirect | ||
| k8s.io/kubectl v0.36.4 // indirect |
| k8s.io/apiextensions-apiserver v0.36.4 // indirect | ||
| k8s.io/klog/v2 v2.140.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260618221249-bc653b64f974 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260721132016-d427ff9ee9ad // indirect |
ab2edaa to
00aef73
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The Makefile’s K8S_VERSION remains on a beta value that won’t match Renovate’s regex and is inconsistent with the PR’s move of k8s.io dependencies to the stable v0.37.0 set.
Review details
Suppressed comments (1)
Makefile:107
- K8S_VERSION is still set to a beta value (v1.37.0-beta.0), but this PR updates the k8s.io/* dependencies to the stable v0.37.0 release and Renovate’s Makefile regex expects a stable vX.Y.Z value. Keeping the beta suffix means Renovate won’t track future K8S_VERSION updates and the Makefile’s stated Kubernetes version won’t align with the dependency set this PR introduces.
GO_VERSION?=1.26.8
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
- Files reviewed: 3/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
00aef73 to
697a1c0
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
K8S_VERSION remains pinned to a beta version in the Makefile despite Kubernetes dependencies being updated to stable v0.37.0, creating an inconsistency in the build toolchain inputs.
Review details
Suppressed comments (1)
Makefile:107
- K8S_VERSION is still set to v1.37.0-beta.0 even though this PR bumps the Kubernetes Go dependencies to v0.37.0 (stable). This makes the go-build image tag (GO_BUILD_VER) inconsistent with the deps, and the comment is misleading since tests/kubectl are driven by ENVTEST_K8S_VERSION and KINDEST_NODE_VERSION/KUBECTL_VERSION instead.
GO_VERSION?=1.26.8
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
- Files reviewed: 3/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The Makefile’s K8S_VERSION remains on v1.37.0-beta.0, which can desynchronize the go-build image/toolchain from the newly-stabilized Kubernetes module versions.
Review details
Suppressed comments (1)
Makefile:109
- K8S_VERSION is still set to v1.37.0-beta.0 even though this PR bumps Kubernetes Go module dependencies to the stable v0.37.0 release; since GO_BUILD_VER bakes K8S_VERSION into the calico/go-build image tag, this can lead to a mismatched build toolchain/image versus the Go module versions.
GO_VERSION?=1.26.8
# Version of Kubernetes to use for dependencies, tests, and kubectl.
K8S_VERSION?=v1.37.0-beta.0
# The version of LLVM to use for the go-build image.
LLVM_VERSION?=21.1.8
- Files reviewed: 3/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
This PR contains the following updates:
ubi9-1784675397→ubi9-17884773461.26.5→1.26.8v0.37.0-beta.0→v0.37.0v0.37.0-beta.0→v0.37.0v0.36.2→v0.36.4v0.37.0-beta.0→v0.37.0v0.37.0-beta.0→v0.37.0v0.36.2→v0.36.4v0.37.0-beta.0→v0.37.0v0.37.0-beta.0→v0.37.0v0.37.0-beta.0→v0.37.0v0.36.2→v0.36.4Release Notes
kubernetes/api (k8s.io/api)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/apiextensions-apiserver (k8s.io/apiextensions-apiserver)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/apiserver (k8s.io/apiserver)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/cli-runtime (k8s.io/cli-runtime)
v0.36.4Compare Source
v0.36.3Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/component-base (k8s.io/component-base)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/kube-aggregator (k8s.io/kube-aggregator)
v0.37.0Compare Source
v0.37.0-rc.1Compare Source
v0.37.0-rc.0Compare Source
kubernetes/kubectl (k8s.io/kubectl)
v0.36.4Compare Source
v0.36.3Compare Source