Auto: sync versions [master] - #5304
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
marvin-tigera
approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The CRD schema tightening (removing Degraded from an enum) and the new admission embed helper naming issues should be addressed/confirmed to avoid upgrade-time validation problems and reduce confusion.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Automated sync PR that refreshes generated/imported CRDs and related assets on master (via make gen-versions), including introducing small Go helpers for serving embedded YAML content.
Changes:
- Add new
embed.gohelpers to expose generated Calico/Enterprise CRD YAMLs asfs.FS. - Add new
embed.gohelpers to expose generated admission policy YAMLs asfs.FS. - Tighten the ApplicationLayer WAF CRD schema by removing
Degradedfrom thesecurityPostureenum in multiple generated CRD YAMLs.
File summaries
| File | Description |
|---|---|
| pkg/imports/crds/enterprise/v3.projectcalico.org/embed.go | New helper package to embed Enterprise v3 projectcalico.org CRD YAMLs. |
| pkg/imports/crds/enterprise/v1.crd.projectcalico.org/embed.go | New helper package to embed Enterprise v1 crd.projectcalico.org CRD YAMLs. |
| pkg/imports/crds/enterprise/v1.crd.projectcalico.org/applicationlayer.projectcalico.org_wafvalidationpolicies.yaml | Removes Degraded from securityPosture enum (schema tightening). |
| pkg/imports/crds/enterprise/v1.crd.projectcalico.org/applicationlayer.projectcalico.org_wafpolicies.yaml | Removes Degraded from securityPosture enum (schema tightening). |
| pkg/imports/crds/enterprise/applicationlayer.projectcalico.org/applicationlayer.projectcalico.org_wafvalidationpolicies.yaml | Removes Degraded from securityPosture enum (schema tightening). |
| pkg/imports/crds/enterprise/applicationlayer.projectcalico.org/applicationlayer.projectcalico.org_wafpolicies.yaml | Removes Degraded from securityPosture enum (schema tightening). |
| pkg/imports/crds/calico/v3.projectcalico.org/embed.go | New helper package to embed Calico v3 projectcalico.org CRD YAMLs. |
| pkg/imports/crds/calico/v1.crd.projectcalico.org/embed.go | New helper package to embed Calico v1 crd.projectcalico.org CRD YAMLs. |
| pkg/imports/admission/enterprise/embed.go | New helper package to embed Enterprise admission policy YAMLs. |
| pkg/imports/admission/calico/embed.go | New helper package to embed Calico admission policy YAMLs. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
360
to
364
| enum: | ||
| - Compliant | ||
| - Warning | ||
| - Degraded | ||
| - Critical | ||
| type: string |
Comment on lines
185
to
189
| enum: | ||
| - Compliant | ||
| - Warning | ||
| - Degraded | ||
| - Critical | ||
| type: string |
Comment on lines
360
to
364
| enum: | ||
| - Compliant | ||
| - Warning | ||
| - Degraded | ||
| - Critical | ||
| type: string |
Comment on lines
185
to
189
| enum: | ||
| - Compliant | ||
| - Warning | ||
| - Degraded | ||
| - Critical | ||
| type: string |
Comment on lines
+24
to
+30
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds | ||
| } |
Comment on lines
+24
to
+30
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds | ||
| } |
github-actions
Bot
force-pushed
the
auto-sync-versions-master
branch
from
September 10, 2026 08:10
f1156f1 to
0a539fa
Compare
Contributor
|
Removing "merge-when-ready" label due to new commits |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It updates installed CRD schemas (potentially affecting upgrade/runtime validation) and should receive a final human review despite being generated.
Review details
Suppressed comments (2)
pkg/imports/admission/calico/embed.go:29
- The embedded filesystem variable is named
crds, but this package embeds admission policy YAML, not CRDs. Renaming the variable would avoid confusion for future readers.
//go:embed *.yaml
var crds embed.FS
// FS returns the admission policy YAML in this directory.
func FS() fs.FS {
return crds
pkg/imports/admission/enterprise/embed.go:29
- The embedded filesystem variable is named
crds, but this package embeds admission policy YAML, not CRDs. Renaming the variable would avoid confusion for future readers.
//go:embed *.yaml
var crds embed.FS
// FS returns the admission policy YAML in this directory.
func FS() fs.FS {
return crds
- Files reviewed: 10/10 changed files
- Comments generated: 0 new
- Review effort level: Lite
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of versions and CRDs from Calico and Calico Enterprise into
masterviamake gen-versions.Triggered by scheduled workflow.