Repository navigation
chore(tooling): keep biome off Markdown and YAML after the 2.6 upgrade - #392
Open
katieschilling wants to merge 1 commit into
Open
katieschilling wants to merge 1 commit into
katieschilling wants to merge 1 commit into
Conversation
Biome 2.6 formats Markdown and YAML by default, which made `pnpm check` fail on main with 18 errors in READMEs, CHANGELOGs, workflows, pnpm-lock.yaml and specs.yaml. Several of those are generated (changesets, pnpm), so formatting them would churn on every release. Disable the two new formatters to restore the pre-upgrade behavior and point $schema at the installed version. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hqe2uWQDRZXDwo7DZEu5En
Contributor
[Low impact] This PR appears safe to merge; no actionable issues were found. SummaryUpdates
Reviews (1) · Last reviewed commit: "chore(tooling): keep biome off Markdown ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm checkfails onmainsince the biome 2.6.3 bump (#389): biome 2.6 formats Markdown and YAML by default and flags 18 files (READMEs,AGENTS.md, the generatedCHANGELOG.mdfiles,pnpm-lock.yaml,pnpm-workspace.yaml, two workflows,specs.yaml). Because the pre-commit hook runspnpm check, every commit on the repo currently needsHUSKY=0.This restores the pre-upgrade behavior by disabling the two new formatters in
biome.json, rather than reformatting the files:CHANGELOG.mdandpnpm-lock.yamlare regenerated by changesets and pnpm and would drift again on the next release. It also bumps$schemato the installed version, which clears the "schema version does not match" info.If we do want biome to own Markdown/YAML, that should be its own change with the generated files excluded and the rest formatted in one commit.
Test plan
biome check .: 496 files, 0 errors, 0 infoUnblocks #372 (which otherwise fails the hook on its changeset file).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Hqe2uWQDRZXDwo7DZEu5En
Note
Low Risk
Config-only change to Biome formatters; no runtime, auth, or business logic is affected.
Overview
Biome 2.6 turns on Markdown and YAML formatting by default, which was breaking
pnpm check/ pre-commit on generated docs and lockfiles. This PR restores pre-upgrade behavior by explicitly disabling those formatters inbiome.json, and updates$schemato 2.6.3 so it matches the installed Biome version.No application or package source files are changed—only tooling config.
Reviewed by Cursor Bugbot for commit 257f1e8. Bugbot is set up for automated code reviews on this repo. Configure here.