Remove ignore whitespace#155
Closed
jfountain wants to merge 9 commits intotiimgreen:masterfrom
jfountain:remove-ignore-whitespace
Closed
Remove ignore whitespace#155jfountain wants to merge 9 commits intotiimgreen:masterfrom jfountain:remove-ignore-whitespace
jfountain wants to merge 9 commits intotiimgreen:masterfrom
jfountain:remove-ignore-whitespace
Conversation
Removed reference to whitespace feature that is no longer supported.
Removed reference to whitespace feature that is no longer supported.
Removed reference to whitespace feature that is no longer supported.
Removed reference to whitespace feature that is no longer supported.
Removed reference to whitespace feature that is no longer supported.
|
It still works on commit page diffs (for example, see dkim1116@a016269?w=1 from #154) |
Contributor
|
I think they just didn't implement everything in the new PR commit pages. For example |
Author
|
Interesting that it's not consistent. I'm going to contact github support directly on this. It may have been a regression bug on the new PR pages. Or maybe the feature is going to be removed on all diff pages. Either way I'll close this for now and re-open depending on feedback from github. |
Closed
Author
|
I heard back from Github on this and they turned the feature back on for pull requests. All rejoice! Thanks @rsese |
Owner
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately github seems to have discontinued the '?w=1' whitespace hiding feature. Noticed this about a week ago.