Repository navigation
runtime: preserve exact timer ordering - #6058
Open
davecheney wants to merge 1 commit into
Open
davecheney wants to merge 1 commit into
davecheney wants to merge 1 commit into
Conversation
Rounding both deadlines first discards information and adds work. The direct comparison preserves deadline order and removes division from queue insertion. Equal deadlines still keep insertion order.
Contributor
Author
|
This has no visible difference impact on the size tests because the existing size tests do not exercise timers, #6059 covers this. |
Member
|
Timer queue is becoming a heap. #6035. I'll make sure this change is incorporated. |
0pcom
added a commit
to 0magnet/tinygo
that referenced
this pull request
Oct 28, 2026
The heap kept its own copy of the deadline in timerNode.when. A timer's deadline only changes while none of its nodes is queued, so the heap can compare timer.when directly, like the list does after tinygo-org#6058. This drops the copy and makes whenTicks the same as on dev again. Equal deadlines still keep insertion order through seq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rounding both deadlines first discards information and adds work. The direct comparison preserves deadline order and removes division from queue insertion. Equal deadlines still keep insertion order.