Repository navigation
internal/task: fix crash when a timer fires into a contended channel with -scheduler=cores - #6060
Open
davecheney wants to merge 1 commit into
Open
davecheney wants to merge 1 commit into
davecheney wants to merge 1 commit into
Conversation
…with -scheduler=cores Timer callbacks run on the scheduler stack with no current goroutine. If the channel lock is held by another core, the callback tried to sleep as a nil task, faulted while holding the global futex lock, and left the other core stalled. Spinning in that case lets the timer send complete once the other core releases the channel lock. Updates tinygo-org#6047
davecheney
force-pushed
the
davecheney-investigate-issue-6047
branch
from
October 28, 2026 02:47
296ff0b to
222b7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timer callbacks run on the scheduler stack with no current goroutine. If the channel lock is held by another core, the callback tried to sleep as a nil task, faulted while holding the global futex lock, and left the other core stalled. Spinning in that case lets the timer send complete once the other core releases the channel lock.
Updates #6047