feat: replace mouse/touch events with pointer events#879
Merged
Conversation
- Use unified Pointer Events API for all drag interactions (mouse, touch, pen) - Implement pointer capture for better drag UX (prevents cursor blinking) - Simplify useResizer hook by removing separate mouse/touch handlers - Update DividerProps to use onPointerDown instead of onMouseDown/onTouchStart/onTouchEnd - Update ResizeEvent source type from 'mouse' | 'touch' to 'pointer' - Add PointerEvent polyfill for jsdom in test setup Closes #878
- Filter pointer events by pointerId to handle multi-touch correctly - Explicitly release pointer capture on drag end - Add tests for multi-touch scenarios and pointer capture release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
handleMouseDown,handleTouchStart,handleTouchEndwith singlehandlePointerDown. Updated global listeners to usepointermove,pointerup,pointercancelonMouseDown/onTouchStart/onTouchEndto singleonPointerDownprophandlePointerDownfrom useResizer hookDividerPropsto useonPointerDown, changedResizeEvent.sourcefrom'mouse' | 'touch'to'pointer'Breaking Changes
Custom divider components will need to update their props:
onMouseDown,onTouchStart,onTouchEndwithonPointerDownBenefits
Browser Support
Pointer Events are supported in all modern browsers (IE11+, Chrome 55+, Firefox 59+, Safari 13+).
Test Plan
Closes #878