Repository navigation
🔧 build(lint): bump simplint to 0.10.1 - #258
Open
gaborbernat wants to merge 14 commits into
Open
gaborbernat wants to merge 14 commits into
gaborbernat wants to merge 14 commits into
Conversation
for more information, see https://pre-commit.ci
gaborbernat
changed the base branch from
fix/expired-release-cutoff
to
fix/windows-test-assumptions
November 10, 2026 16:37
gaborbernat
changed the base branch from
fix/windows-test-assumptions
to
stack/windows-test-assumptions
November 10, 2026 16:39
Windows registry discovery and proposal previously crossed two private module boundaries. Keep them together and move tests alongside the modules they cover. Pass PEP 514 arguments through PythonInfo.from_exe so the proposer no longer calls a private method from another module.
Registry tests patched os.path.exists, forcing a module-wide Ruff exemption. Use Path.exists in production and tests, and join registry paths as Windows paths on every test host.
The test attached an undeclared attribute to candidate interpreters only to identify the selected result. Compare its public traits instead and remove the type-checker suppression.
The subprocess suppression said command formatting was only for logs, although PEP 514 arguments use the formatted command line. State the actual reason for interpreter interrogation and correct the probe's string-path rationale.
Long inline reasons obscured Windows registry code and prompted an expanded subprocess import. Move explanations beside long statements and keep each suppression tied to its platform or API constraint.
Python 3.9 setuptools reads sys.version_info.major while collecting interpreter metadata. Use a local named tuple for mocked versions so tests keep the same field access as the real value without importing a private module.
gaborbernat
marked this pull request as ready for review
November 10, 2026 17:26
gaborbernat
marked this pull request as draft
November 10, 2026 17:44
gaborbernat
marked this pull request as ready for review
November 10, 2026 17:47
gaborbernat
marked this pull request as draft
November 10, 2026 19:27
gaborbernat
changed the title
gaborbernat
marked this pull request as ready for review
November 10, 2026 20:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplint pre-commit hook now uses v0.10.1, which checks private import paths. Windows registry discovery and proposal share one internal module, and tests mirror the modules they cover.
PEP 514 executable arguments pass through the existing public
PythonInfo.from_exemethod. The remaining private-import ignores cover Python's platform modules and synthetic Windows registry test data.