Skip to content

Fix(webapp): logs button + logs table row link fix #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samejr merged 7 commits into from
Feb 20, 2026
Merged

Fix(webapp): logs button + logs table row link fix #3107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d0fcfa9
Button variant change to secondary
samejr Feb 20, 2026
1636984
Add missing row click handler
samejr Feb 20, 2026
e4dea2b
Improved link to run button style on a row
samejr Feb 20, 2026
8446718
Better tooltip behaviour
samejr Feb 20, 2026
4cfc055
Pass through disableTooltipHoverableContent
samejr Feb 20, 2026
7691f82
Merge branch 'main' into fix(webapp)-logs-button
samejr Feb 20, 2026
67c6e1a
Merge branch 'main' into fix(webapp)-logs-button
samejr Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/webapp/app/components/logs/LogDetailView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ function DetailsTab({
<CopyableText value={log.runId} copyValue={log.runId} asChild />
<LinkButton
to={runPath}
variant="tertiary/small"
variant="secondary/small"
shortcut={{ key: "v" }}
className="mt-2"
>
Expand Down
10 changes: 7 additions & 3 deletions apps/webapp/app/components/logs/LogsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
TableRow,
type TableVariant,
} from "../primitives/Table";
import { RunsIcon } from "~/assets/icons/RunsIcon";

type LogsTableProps = {
logs: LogEntry[];
Expand Down Expand Up @@ -124,6 +125,7 @@ export function LogsTable({
<TableHeaderCell
className="min-w-24 whitespace-nowrap"
tooltip={<LogLevelTooltipInfo />}
disableTooltipHoverableContent
>
Level
</TableHeaderCell>
Expand Down Expand Up @@ -165,7 +167,7 @@ export function LogsTable({
>
<DateTimeAccurate date={log.triggeredTimestamp} hour12={false} />
</TableCell>
<TableCell className="min-w-24">
<TableCell className="min-w-24" onClick={handleRowClick} hasAction>
<TruncatedCopyableValue value={log.runId} />
</TableCell>
<TableCell className="min-w-32" onClick={handleRowClick} hasAction>
Expand All @@ -185,9 +187,11 @@ export function LogsTable({
<LinkButton
to={runPath}
variant="minimal/small"
TrailingIcon={ArrowTopRightOnSquareIcon}
TrailingIcon={RunsIcon}
trailingIconClassName="text-text-bright"
className="h-[1.375rem] pl-1.5 pr-2"
>
View run
<span className="text-[0.6875rem] text-text-bright">View run</span>
</LinkButton>
}
/>
Expand Down
15 changes: 14 additions & 1 deletion apps/webapp/app/components/primitives/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,22 @@ type TableCellBasicProps = {
type TableHeaderCellProps = TableCellBasicProps & {
hiddenLabel?: boolean;
tooltip?: ReactNode;
disableTooltipHoverableContent?: boolean;
};

export const TableHeaderCell = forwardRef<HTMLTableCellElement, TableHeaderCellProps>(
({ className, alignment = "left", children, colSpan, hiddenLabel = false, tooltip }, ref) => {
(
{
className,
alignment = "left",
children,
colSpan,
hiddenLabel = false,
tooltip,
disableTooltipHoverableContent = false,
},
ref
) => {
const { variant } = useContext(TableContext);
let alignmentClassName = "text-left";
switch (alignment) {
Expand Down Expand Up @@ -222,6 +234,7 @@ export const TableHeaderCell = forwardRef<HTMLTableCellElement, TableHeaderCellP
content={tooltip}
contentClassName="normal-case tracking-normal"
enabled={isHovered}
disableHoverableContent={disableTooltipHoverableContent}
/>
</div>
) : (
Expand Down