Skip to content

chore: release v4.4.6#3501

Merged
matt-aitken merged 1 commit into
mainfrom
changeset-release/main
May 12, 2026
Merged

chore: release v4.4.6#3501
matt-aitken merged 1 commit into
mainfrom
changeset-release/main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 1, 2026

Summary

1 improvement, 1 bug fix.

Improvements

  • Fail attempts on uncaught exceptions instead of hanging to MAX_DURATION_EXCEEDED. A Node EventEmitter (e.g. node-redis) emitting "error" with no .on("error", ...) listener escalates to uncaughtException, which the worker previously reported but did not act on — runs drifted to maxDuration with empty attempts. They now fail fast with the original error and status FAILED, and respect the task's normal retry policy. You should still attach .on("error", ...) listeners to long-lived clients to handle errors gracefully. (#3529)

Bug fixes

  • Fix dev workers spinning at 100% CPU after the parent CLI disconnects. Orphaned trigger-dev-run-worker (and indexer) processes were caught in an uncaughtException feedback loop: a periodic IPC send via process.send would throw ERR_IPC_CHANNEL_CLOSED once the parent closed the channel, which re-entered the same handler that itself called process.send, scheduled via setImmediate and amplified by source-map-support's prepareStackTrace. Fixed by (1) silently dropping packets in ZodIpcConnection when the channel is disconnected, (2) adding a process.on("disconnect", ...) handler in dev workers so they exit cleanly when the CLI closes the IPC channel, and (3) wrapping all uncaughtException-path process.send calls in a safeSend guard that checks process.connected and swallows synchronous throws. (#3491)
Raw changeset output

Releases

@trigger.dev/[email protected]

Patch Changes

[email protected]

Patch Changes

  • Fix dev workers spinning at 100% CPU after the parent CLI disconnects. Orphaned trigger-dev-run-worker (and indexer) processes were caught in an uncaughtException feedback loop: a periodic IPC send via process.send would throw ERR_IPC_CHANNEL_CLOSED once the parent closed the channel, which re-entered the same handler that itself called process.send, scheduled via setImmediate and amplified by source-map-support's prepareStackTrace. Fixed by (1) silently dropping packets in ZodIpcConnection when the channel is disconnected, (2) adding a process.on("disconnect", ...) handler in dev workers so they exit cleanly when the CLI closes the IPC channel, and (3) wrapping all uncaughtException-path process.send calls in a safeSend guard that checks process.connected and swallows synchronous throws. (#3491)
  • Fail attempts on uncaught exceptions instead of hanging to MAX_DURATION_EXCEEDED. A Node EventEmitter (e.g. node-redis) emitting "error" with no .on("error", ...) listener escalates to uncaughtException, which the worker previously reported but did not act on — runs drifted to maxDuration with empty attempts. They now fail fast with the original error and status FAILED, and respect the task's normal retry policy. You should still attach .on("error", ...) listeners to long-lived clients to handle errors gracefully. (#3529)
  • Updated dependencies:

@trigger.dev/[email protected]

Patch Changes

  • Fix dev workers spinning at 100% CPU after the parent CLI disconnects. Orphaned trigger-dev-run-worker (and indexer) processes were caught in an uncaughtException feedback loop: a periodic IPC send via process.send would throw ERR_IPC_CHANNEL_CLOSED once the parent closed the channel, which re-entered the same handler that itself called process.send, scheduled via setImmediate and amplified by source-map-support's prepareStackTrace. Fixed by (1) silently dropping packets in ZodIpcConnection when the channel is disconnected, (2) adding a process.on("disconnect", ...) handler in dev workers so they exit cleanly when the CLI closes the IPC channel, and (3) wrapping all uncaughtException-path process.send calls in a safeSend guard that checks process.connected and swallows synchronous throws. (#3491)
  • Fail attempts on uncaught exceptions instead of hanging to MAX_DURATION_EXCEEDED. A Node EventEmitter (e.g. node-redis) emitting "error" with no .on("error", ...) listener escalates to uncaughtException, which the worker previously reported but did not act on — runs drifted to maxDuration with empty attempts. They now fail fast with the original error and status FAILED, and respect the task's normal retry policy. You should still attach .on("error", ...) listeners to long-lived clients to handle errors gracefully. (#3529)

@trigger.dev/[email protected]

Patch Changes

@trigger.dev/[email protected]

Patch Changes

@trigger.dev/[email protected]

Patch Changes

@trigger.dev/[email protected]

Patch Changes

@trigger.dev/[email protected]

Patch Changes

@trigger.dev/[email protected]

Patch Changes

@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 1, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 2, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from b577d8c to 78e90b9 Compare May 2, 2026 08:47
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 2, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

nicktrn pushed a commit that referenced this pull request May 2, 2026
## Summary

Delete 34 `.server-changes/*.md` files that should have been cleaned up
automatically when v4.4.5 (#3406) was merged but were stranded by a
workflow race.

## Why these are stale

The `update-lockfile` job in `.github/workflows/changesets-pr.yml` is
what cleans up consumed `.server-changes/*.md` files on the release
branch. When v4.4.5 was merged on 2026-05-01, the post-merge workflow
run on `main` failed at `pnpm install --frozen-lockfile` (stale lockfile
in the merge commit), and `cancel-in-progress: true` cancelled the
in-flight run from the previous push — so `update-lockfile` never
reached the cleanup step.

Result: the 34 files described changes that v4.4.5 already shipped, and
they were re-appearing in the v4.4.6 release PR (#3501) under "Server
changes" plus showing up as deletions in its diff.

## What this PR keeps

- `fix-rollback-schedule-sync.md` — genuinely new for v4.4.6 (#3468),
the only server change introduced after v4.4.5
- `README.md`, `.gitkeep` — directory infrastructure
- `dev-cli-disconnect-md` — leaving alone (typo'd filename from March,
no `.md` extension, not picked up by the cleanup glob anyway)

## After merge

The next run of `changesets-pr.yml` will refresh #3501 with a "Server
changes" section that only lists the v4.4.6 entry, and the only
`.server-changes/` deletion in its diff will be
`fix-rollback-schedule-sync.md`.

## Related

- #3505 is the proper underlying fix — collapses the three-job graph
into a single atomic commit by `changesets/action` so this race can't
strand the cleanup again. This PR is just the one-time catch-up for the
files that already got stranded.
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 2, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 78e90b9 to d33a6d8 Compare May 2, 2026 08:56
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 2, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 4, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from d33a6d8 to 3c30308 Compare May 4, 2026 14:04
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 4, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 5, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 3c30308 to f683200 Compare May 5, 2026 09:08
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 5, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 5, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from f683200 to 275bbe8 Compare May 5, 2026 10:33
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 5, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 5, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 275bbe8 to 470d032 Compare May 5, 2026 13:54
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 5, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 6, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 470d032 to 3f05742 Compare May 6, 2026 18:37
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 6, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 8, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 3f05742 to 6471706 Compare May 8, 2026 10:48
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 8, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 8, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 6471706 to d774377 Compare May 8, 2026 15:27
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 8, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 9, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from d774377 to bada550 Compare May 9, 2026 08:01
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 9, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 10, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from bada550 to 6539e6e Compare May 10, 2026 20:32
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 10, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 11, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 6539e6e to d0e944b Compare May 11, 2026 06:18
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 11, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 11, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from d0e944b to 25ca1b4 Compare May 11, 2026 10:04
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 11, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 11, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from 25ca1b4 to b173837 Compare May 11, 2026 14:23
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 11, 2026
@github-actions github-actions Bot changed the title chore: release v4.4.6 chore: release May 12, 2026
@github-actions github-actions Bot force-pushed the changeset-release/main branch from b173837 to d625889 Compare May 12, 2026 07:00
@github-actions github-actions Bot changed the title chore: release chore: release v4.4.6 May 12, 2026
@matt-aitken matt-aitken merged commit 41a486e into main May 12, 2026
6 checks passed
@matt-aitken matt-aitken deleted the changeset-release/main branch May 12, 2026 10:33
@matt-aitken matt-aitken deployed to npm-publish May 12, 2026 10:33 — with GitHub Actions Active
ConProgramming added a commit to GovSignals/trigger.dev that referenced this pull request May 15, 2026
Reconciles plt-663-chart-fixes with gs-v4.4.4's main-merge (PR #12).

Conflicts resolved:
  - hosting/k8s/helm/Chart.yaml      -> hand-merged: bumped prerelease
    base from 4.4.5 to 4.4.6 to track gs-v4.4.4's version bump (PR triggerdotdev#3500
    + triggerdotdev#3501 from upstream). New chart version is now 4.4.6-plt663.1.
    appVersion v4.4.6 from upstream.
  - hosting/k8s/helm/Chart.lock      -> took gs-v4.4.4's lock (clickhouse
    9.4.4 from upstream PR triggerdotdev#3524) then re-ran `helm dependency build`.

Auto-merged cleanly:
  - hosting/k8s/helm/templates/supervisor.yaml (our security-context env
    wiring + worker pod annotations type fix preserved alongside upstream's
    extraVolumes/extraVolumeMounts and OTLP fully-qualified URL).

Upstream-coverage check (4 PR #13 fixes vs newly-synced upstream main):
  - _helpers.tpl  ($(CLICKHOUSE_PASSWORD) in deploy: true branch) -> NOVEL
    Upstream's deploy branch still interpolates `.Values.clickhouse.auth.password`
    literally; our fix is still required when auth.existingSecret is set.
  - electric.yaml (/app/persistent mount + extraVolumes)          -> NOVEL
    Upstream electric.yaml still renders no volumes/volumeMounts at all.
  - webapp.yaml   (S3 useIam gate + CLICKHOUSE_PASSWORD env)      -> NOVEL
    Upstream webapp.yaml has no useIam reference and no CLICKHOUSE_PASSWORD
    env var; both are still required.
  - values.yaml   (electric.extraVolumes + s3.external.useIam)    -> NOVEL
    Upstream values.yaml has neither key under electric: nor s3.external:.

All 4 fixes remain net-new fork-side patches. No PR #13 commits become
redundant from this upstream sync.

Smoke tests:
  - helm dependency build hosting/k8s/helm        OK
  - helm template hosting/k8s/helm                OK (renders v4.4.6-plt663.1)

Co-authored-by: Cursor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant