Skip to content

In svg_draw, move the y axis when there's a title#3452

Open
hyanwong wants to merge 1 commit intotskit-dev:mainfrom
hyanwong:fix-y-axis-drawing
Open

In svg_draw, move the y axis when there's a title#3452
hyanwong wants to merge 1 commit intotskit-dev:mainfrom
hyanwong:fix-y-axis-drawing

Conversation

@hyanwong
Copy link
Copy Markdown
Member

Fixes #3451

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.67%. Comparing base (9be15c4) to head (a163b65).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3452   +/-   ##
=======================================
  Coverage   91.66%   91.67%           
=======================================
  Files          38       38           
  Lines       32184    32186    +2     
  Branches     5150     5150           
=======================================
+ Hits        29503    29505    +2     
  Misses       2348     2348           
  Partials      333      333           
Flag Coverage Δ
C 82.23% <ø> (ø)
c-python 77.54% <ø> (ø)
python-tests 96.40% <100.00%> (+<0.01%) ⬆️
python-tests-no-jit 33.20% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Python API 98.70% <100.00%> (+<0.01%) ⬆️
Python C interface 91.23% <ø> (ø)
C library 91.24% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hyanwong hyanwong force-pushed the fix-y-axis-drawing branch from 68b9a6b to a163b65 Compare May 4, 2026 11:37
@hyanwong
Copy link
Copy Markdown
Member Author

hyanwong commented May 4, 2026

I'm keen to merge this, as it's a minor bug fix which is holding up some of the tutorials. I'm not sure who is well placed to look it over now: perhaps if @benjeffery has a moment, although it'll be entirely voluntary!

Here's a before and after screengrab:

Before

Screenshot 2026-05-04 at 12 50 14

(note the position of the 0 point on the y axis, and the cutting-off of the y axis title)

After

Screenshot 2026-05-04 at 12 51 48

hyanwong added a commit to hyanwong/tutorials that referenced this pull request May 4, 2026
Waiting on tskit-dev/tskit#3452 before merging, due to adding titles to plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

draw_svg: Y-axis height bug with title

1 participant