feat: add setAttributes API to FileSysteming protocol#278
Merged
Conversation
This allows setting the last access and modification times of a file or directory through the FileSysteming protocol. On non-Windows platforms it uses NIO's async FileHandle.setTimes API, and on Windows it falls back to FileManager.
pepicrft
force-pushed
the
feat/set-last-modification-date
branch
from
91b0ddd to
ac101ca
Compare
fortmarek
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a generic
setAttributesAPI to theFileSystemingprotocol so callers can set file attributes (modification date, POSIX permissions) without reaching forFileManagerdirectly.The implementation uses a type-safe
FileAttributeenum that maps toFileAttributeKeyvalues under the hood. TheFileManager.setAttributescall is dispatched off the main thread viaTask.